Commit a01d8dc
authored
Bazel Credential Helper Bugfix Time Format Issue (#633)
* Bugfix Time Format Issue
Bugfix time conversion issue when converting from time.RFC3339 to time.UnixDate as this
is problematic because RFC3339 is a standardized, unambiguous format with timezone
information (e.g., "2023-01-01T12:00:00Z"), while UnixDate is a human-readable
format without explicit timezone indicators (e.g., "Sun Jan 1 12:00:00 GMT 2023").
This conversion can lead to timezone ambiguity and parsing errors in systems
expecting RFC3339 format, potentially causing authentication failures.
Convert to UTC to avoid parsing errors when timezone can't be determined.
* Incorporate Review Feedback
Switch to much simpler construct..1 parent 23d034e commit a01d8dc
1 file changed
+9
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
57 | 65 | | |
58 | | - | |
| 66 | + | |
59 | 67 | | |
60 | 68 | | |
61 | 69 | | |
| |||
0 commit comments