Skip to content

Commit 3860ca2

Browse files
mostynbmostynb
authored
Rename CacheCapabilities' blob_split_support to split_blob_support and blob_splice_support to splice_blob_support (#340)
This now matches the names of the actual RPC calls. Fixes #339
1 parent 0425bb9 commit 3860ca2

File tree

3 files changed

+19
-19
lines changed

3 files changed

+19
-19
lines changed

‎build/bazel/remote/execution/v2/remote_execution.pb.go‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4393,13 +4393,13 @@ type CacheCapabilities struct {
43934393
// splitting and a meaningful result can be expected from the
43944394
// [ContentAddressableStorage.SplitBlob][build.bazel.remote.execution.v2.ContentAddressableStorage.SplitBlob]
43954395
// operation.
4396-
BlobSplitSupport bool `protobuf:"varint,9,opt,name=blob_split_support,json=blobSplitSupport,proto3" json:"blob_split_support,omitempty"`
4396+
SplitBlobSupport bool `protobuf:"varint,9,opt,name=split_blob_support,json=splitBlobSupport,proto3" json:"split_blob_support,omitempty"`
43974397
// Whether blob splicing is supported for the particular server/instance. If
43984398
// yes, the server/instance implements the specified behavior for blob
43994399
// splicing and a meaningful result can be expected from the
44004400
// [ContentAddressableStorage.SpliceBlob][build.bazel.remote.execution.v2.ContentAddressableStorage.SpliceBlob]
44014401
// operation.
4402-
BlobSpliceSupport bool `protobuf:"varint,10,opt,name=blob_splice_support,json=blobSpliceSupport,proto3" json:"blob_splice_support,omitempty"`
4402+
SpliceBlobSupport bool `protobuf:"varint,10,opt,name=splice_blob_support,json=spliceBlobSupport,proto3" json:"splice_blob_support,omitempty"`
44034403
}
44044404

44054405
func (x *CacheCapabilities) Reset() {
@@ -4490,16 +4490,16 @@ func (x *CacheCapabilities) GetMaxCasBlobSizeBytes() int64 {
44904490
return 0
44914491
}
44924492

4493-
func (x *CacheCapabilities) GetBlobSplitSupport() bool {
4493+
func (x *CacheCapabilities) GetSplitBlobSupport() bool {
44944494
if x != nil {
4495-
return x.BlobSplitSupport
4495+
return x.SplitBlobSupport
44964496
}
44974497
return false
44984498
}
44994499

4500-
func (x *CacheCapabilities) GetBlobSpliceSupport() bool {
4500+
func (x *CacheCapabilities) GetSpliceBlobSupport() bool {
45014501
if x != nil {
4502-
return x.BlobSpliceSupport
4502+
return x.SpliceBlobSupport
45034503
}
45044504
return false
45054505
}
@@ -5999,12 +5999,12 @@ var file_build_bazel_remote_execution_v2_remote_execution_proto_rawDesc = []byte
59995999
0x6d, 0x61, 0x78, 0x5f, 0x63, 0x61, 0x73, 0x5f, 0x62, 0x6c, 0x6f, 0x62, 0x5f, 0x73, 0x69, 0x7a,
60006000
0x65, 0x5f, 0x62, 0x79, 0x74, 0x65, 0x73, 0x18, 0x08, 0x20, 0x01, 0x28, 0x03, 0x52, 0x13, 0x6d,
60016001
0x61, 0x78, 0x43, 0x61, 0x73, 0x42, 0x6c, 0x6f, 0x62, 0x53, 0x69, 0x7a, 0x65, 0x42, 0x79, 0x74,
6002-
0x65, 0x73, 0x12, 0x2c, 0x0a, 0x12, 0x62, 0x6c, 0x6f, 0x62, 0x5f, 0x73, 0x70, 0x6c, 0x69, 0x74,
6002+
0x65, 0x73, 0x12, 0x2c, 0x0a, 0x12, 0x73, 0x70, 0x6c, 0x69, 0x74, 0x5f, 0x62, 0x6c, 0x6f, 0x62,
60036003
0x5f, 0x73, 0x75, 0x70, 0x70, 0x6f, 0x72, 0x74, 0x18, 0x09, 0x20, 0x01, 0x28, 0x08, 0x52, 0x10,
6004-
0x62, 0x6c, 0x6f, 0x62, 0x53, 0x70, 0x6c, 0x69, 0x74, 0x53, 0x75, 0x70, 0x70, 0x6f, 0x72, 0x74,
6005-
0x12, 0x2e, 0x0a, 0x13, 0x62, 0x6c, 0x6f, 0x62, 0x5f, 0x73, 0x70, 0x6c, 0x69, 0x63, 0x65, 0x5f,
6006-
0x73, 0x75, 0x70, 0x70, 0x6f, 0x72, 0x74, 0x18, 0x0a, 0x20, 0x01, 0x28, 0x08, 0x52, 0x11, 0x62,
6007-
0x6c, 0x6f, 0x62, 0x53, 0x70, 0x6c, 0x69, 0x63, 0x65, 0x53, 0x75, 0x70, 0x70, 0x6f, 0x72, 0x74,
6004+
0x73, 0x70, 0x6c, 0x69, 0x74, 0x42, 0x6c, 0x6f, 0x62, 0x53, 0x75, 0x70, 0x70, 0x6f, 0x72, 0x74,
6005+
0x12, 0x2e, 0x0a, 0x13, 0x73, 0x70, 0x6c, 0x69, 0x63, 0x65, 0x5f, 0x62, 0x6c, 0x6f, 0x62, 0x5f,
6006+
0x73, 0x75, 0x70, 0x70, 0x6f, 0x72, 0x74, 0x18, 0x0a, 0x20, 0x01, 0x28, 0x08, 0x52, 0x11, 0x73,
6007+
0x70, 0x6c, 0x69, 0x63, 0x65, 0x42, 0x6c, 0x6f, 0x62, 0x53, 0x75, 0x70, 0x70, 0x6f, 0x72, 0x74,
60086008
0x22, 0xb7, 0x03, 0x0a, 0x15, 0x45, 0x78, 0x65, 0x63, 0x75, 0x74, 0x69, 0x6f, 0x6e, 0x43, 0x61,
60096009
0x70, 0x61, 0x62, 0x69, 0x6c, 0x69, 0x74, 0x69, 0x65, 0x73, 0x12, 0x5e, 0x0a, 0x0f, 0x64, 0x69,
60106010
0x67, 0x65, 0x73, 0x74, 0x5f, 0x66, 0x75, 0x6e, 0x63, 0x74, 0x69, 0x6f, 0x6e, 0x18, 0x01, 0x20,

‎build/bazel/remote/execution/v2/remote_execution.proto‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,7 @@ service ContentAddressableStorage {
462462
//
463463
// Servers which implement this functionality MUST declare that they support
464464
// it by setting the
465-
// [CacheCapabilities.blob_split_support][build.bazel.remote.execution.v2.CacheCapabilities.blob_split_support]
465+
// [CacheCapabilities.split_blob_support][build.bazel.remote.execution.v2.CacheCapabilities.split_blob_support]
466466
// field accordingly.
467467
//
468468
// Clients MUST check that the server supports this capability, before using
@@ -514,7 +514,7 @@ service ContentAddressableStorage {
514514
//
515515
// Servers which implement this functionality MUST declare that they support
516516
// it by setting the
517-
// [CacheCapabilities.blob_splice_support][build.bazel.remote.execution.v2.CacheCapabilities.blob_splice_support]
517+
// [CacheCapabilities.splice_blob_support][build.bazel.remote.execution.v2.CacheCapabilities.splice_blob_support]
518518
// field accordingly.
519519
//
520520
// Clients MUST check that the server supports this capability, before using
@@ -2266,14 +2266,14 @@ message CacheCapabilities {
22662266
// splitting and a meaningful result can be expected from the
22672267
// [ContentAddressableStorage.SplitBlob][build.bazel.remote.execution.v2.ContentAddressableStorage.SplitBlob]
22682268
// operation.
2269-
bool blob_split_support = 9;
2269+
bool split_blob_support = 9;
22702270

22712271
// Whether blob splicing is supported for the particular server/instance. If
22722272
// yes, the server/instance implements the specified behavior for blob
22732273
// splicing and a meaningful result can be expected from the
22742274
// [ContentAddressableStorage.SpliceBlob][build.bazel.remote.execution.v2.ContentAddressableStorage.SpliceBlob]
22752275
// operation.
2276-
bool blob_splice_support = 10;
2276+
bool splice_blob_support = 10;
22772277
}
22782278

22792279
// Capabilities of the remote execution system.

‎build/bazel/remote/execution/v2/remote_execution_grpc.pb.go‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -688,7 +688,7 @@ type ContentAddressableStorageClient interface {
688688
//
689689
// Servers which implement this functionality MUST declare that they support
690690
// it by setting the
691-
// [CacheCapabilities.blob_split_support][build.bazel.remote.execution.v2.CacheCapabilities.blob_split_support]
691+
// [CacheCapabilities.split_blob_support][build.bazel.remote.execution.v2.CacheCapabilities.split_blob_support]
692692
// field accordingly.
693693
//
694694
// Clients MUST check that the server supports this capability, before using
@@ -737,7 +737,7 @@ type ContentAddressableStorageClient interface {
737737
//
738738
// Servers which implement this functionality MUST declare that they support
739739
// it by setting the
740-
// [CacheCapabilities.blob_splice_support][build.bazel.remote.execution.v2.CacheCapabilities.blob_splice_support]
740+
// [CacheCapabilities.splice_blob_support][build.bazel.remote.execution.v2.CacheCapabilities.splice_blob_support]
741741
// field accordingly.
742742
//
743743
// Clients MUST check that the server supports this capability, before using
@@ -957,7 +957,7 @@ type ContentAddressableStorageServer interface {
957957
//
958958
// Servers which implement this functionality MUST declare that they support
959959
// it by setting the
960-
// [CacheCapabilities.blob_split_support][build.bazel.remote.execution.v2.CacheCapabilities.blob_split_support]
960+
// [CacheCapabilities.split_blob_support][build.bazel.remote.execution.v2.CacheCapabilities.split_blob_support]
961961
// field accordingly.
962962
//
963963
// Clients MUST check that the server supports this capability, before using
@@ -1006,7 +1006,7 @@ type ContentAddressableStorageServer interface {
10061006
//
10071007
// Servers which implement this functionality MUST declare that they support
10081008
// it by setting the
1009-
// [CacheCapabilities.blob_splice_support][build.bazel.remote.execution.v2.CacheCapabilities.blob_splice_support]
1009+
// [CacheCapabilities.splice_blob_support][build.bazel.remote.execution.v2.CacheCapabilities.splice_blob_support]
10101010
// field accordingly.
10111011
//
10121012
// Clients MUST check that the server supports this capability, before using

0 commit comments

Comments
 (0)