Use a separate feature for cpp std option on Windows

Copybara Import from #443

BEGIN_PUBLIC
Use a separate feature for cpp std option on Windows (#443)

Address #440 (comment)

We should probably do the same for unix cc toolchains, but that needs more clean up first.

Closes #443
END_PUBLIC

COPYBARA_INTEGRATE_REVIEW=#443 from meteorcloudy:msvc_cpp_std 3c4f7b3
PiperOrigin-RevId: 784153348
Change-Id: Ibc1b580d7b5b6df34ec1db70f2005b9002585f65

Author: meteorcloudy

cc/private/toolchain/windows_cc_toolchain_config.bzl

@@ -728,6 +728,21 @@ def _impl(ctx):
             ],
         )
 
+        default_cpp_std_feature = feature(
+            name = "default_cpp_std",
+            enabled = True,
+            flag_sets = [
+                flag_set(
+                    actions = all_cpp_compile_actions,
+                    flag_groups = [
+                        flag_group(
+                            flags = ["/std:c++17"],
+                        ),
+                    ],
+                ),
+            ],
+        )
+
         default_compile_flags_feature = feature(
             name = "default_compile_flags",
             enabled = True,
@@ -751,7 +766,6 @@ def _impl(ctx):
                     flag_groups = [
                         flag_group(
                             flags = [
-                                "/std:c++17",
                                 "/DNOMINMAX",
                                 "/D_WIN32_WINNT=0x0601",
                                 "/D_CRT_SECURE_NO_DEPRECATE",
@@ -1274,6 +1288,7 @@ def _impl(ctx):
             no_stripping_feature,
             targets_windows_feature,
             copy_dynamic_libraries_to_binary_feature,
+            default_cpp_std_feature,
             default_compile_flags_feature,
             msvc_env_feature,
             msvc_compile_env_feature,

tests/simple_binary/BUILD

@@ -26,3 +26,14 @@ cc_binary(
     srcs = ["foo.cc"],
     linkshared = 1,
 )
+
+# Regression test for building C code
+# https://github.com/bazelbuild/rules_cc/pull/440#issuecomment-3075519628
+cc_binary(
+    name = "bar",
+    srcs = ["bar.c"],
+    copts = select({
+        "@platforms//os:windows": ["/std:c11"],
+        "//conditions:default": [],
+    }),
+)

tests/simple_binary/bar.c

@@ -0,0 +1,15 @@
+// Copyright 2023 The Bazel Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+int main(int argc, char *argv[]) { return 0; }