Skip to content

Commit 859967d

Browse files
BADGER-293 Remove video frames not advancing (#417)
1 parent df86bbf commit 859967d

5 files changed

Lines changed: 3 additions & 13 deletions

File tree

docs/tutorials/02-plugins.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ The full interface is as follows:
2424
- `onSubtitlesDynamicLoadError`
2525
- `onFragmentContentLengthMismatch`
2626
- `onPlaybackRateChanged`
27-
- `onPlaybackFrozen`
2827

2928
An example plugin may look like:
3029

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363
"typescript-eslint": "7.2.0"
6464
},
6565
"dependencies": {
66-
"dashjs": "github:bbc/dash.js#smp-v4.7.3-15",
66+
"dashjs": "github:bbc/dash.js#smp-v4.7.3-16",
6767
"smp-imsc": "github:bbc/imscJS#v1.0.11"
6868
},
6969
"repository": {

src/playbackstrategy/msestrategy.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,6 @@ function MSEStrategy(
124124
QUOTA_EXCEEDED: "quotaExceeded",
125125
TEXT_TRACKS_ADDED: "allTextTracksAdded",
126126
CURRENT_TRACK_CHANGED: "currentTrackChanged",
127-
PLAYBACK_FROZEN: "playbackFrozen",
128127
}
129128

130129
function onLoadedMetaData() {
@@ -764,7 +763,6 @@ function MSEStrategy(
764763
mediaPlayer.on(DashJSEvents.TEXT_TRACKS_ADDED, handleTextTracks)
765764
mediaPlayer.on(DashJSEvents.MANIFEST_LOADING_FINISHED, manifestLoadingFinished)
766765
mediaPlayer.on(DashJSEvents.CURRENT_TRACK_CHANGED, onCurrentTrackChanged)
767-
mediaPlayer.on(DashJSEvents.PLAYBACK_FROZEN, onPlaybackFrozen)
768766
}
769767

770768
function handleTextTracks() {
@@ -953,7 +951,6 @@ function MSEStrategy(
953951
mediaPlayer.off(DashJSEvents.GAP_JUMP_TO_END, onGapJump)
954952
mediaPlayer.off(DashJSEvents.QUOTA_EXCEEDED, onQuotaExceeded)
955953
mediaPlayer.off(DashJSEvents.CURRENT_TRACK_CHANGED, onCurrentTrackChanged)
956-
mediaPlayer.off(DashJSEvents.PLAYBACK_FROZEN, onPlaybackFrozen)
957954
mediaPlayer = undefined
958955
}
959956

@@ -1079,11 +1076,6 @@ function MSEStrategy(
10791076
})
10801077
}
10811078

1082-
function onPlaybackFrozen(event) {
1083-
Plugins.interface.onPlaybackFrozen(event)
1084-
DebugTool.info(`${event.cause}. Total frames - ${event.totalVideoFrames}`)
1085-
}
1086-
10871079
return {
10881080
transitions: {
10891081
canBePaused: () => true,

src/plugins.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,5 @@ export default {
8383
onQuotaExceeded: (evt) => callOnAllPlugins("onQuotaExceeded", evt),
8484
onPlaybackQualityChange: (evt) => callOnAllPlugins("onPlaybackQualityChange", evt),
8585
onPlaybackRateChanged: (evt) => callOnAllPlugins("onPlaybackRateChanged", evt),
86-
onPlaybackFrozen: (evt) => callOnAllPlugins("onPlaybackFrozen", evt),
8786
},
8887
}

0 commit comments

Comments
 (0)