Fix type errors on video only content (#393)

Luke-Chatburn · web-flow · commit ad2c27ddb3a0 · 2025-07-10T09:28:50.000+01:00
diff --git a/src/playbackstrategy/msestrategy.js b/src/playbackstrategy/msestrategy.js
@@ -327,13 +327,15 @@ function MSEStrategy(
       mediaPlayer.setMediaDuration(Number.MAX_SAFE_INTEGER)
     }
 
-    if (mediaKind === MediaKinds.VIDEO) {
+    if (mediaPlayer.getActiveStream()?.getHasVideoTrack()) {
       dispatchDownloadQualityChangeForKind(MediaKinds.VIDEO)
       dispatchMaxQualityChangeForKind(MediaKinds.VIDEO)
     }
 
-    dispatchMaxQualityChangeForKind(MediaKinds.AUDIO)
-    dispatchDownloadQualityChangeForKind(MediaKinds.AUDIO)
+    if (mediaPlayer.getActiveStream()?.getHasAudioTrack()) {
+      dispatchMaxQualityChangeForKind(MediaKinds.AUDIO)
+      dispatchDownloadQualityChangeForKind(MediaKinds.AUDIO)
+    }
 
     emitPlayerInfo()
   }
diff --git a/src/playbackstrategy/msestrategy.test.js b/src/playbackstrategy/msestrategy.test.js
@@ -1626,6 +1626,7 @@ describe("Media Source Extensions Playback Strategy", () => {
 
       mockDashInstance.isReady.mockReturnValue(true)
       mockDashInstance.getTopBitrateInfoFor.mockReturnValue({ qualityIndex: 2, bitrate: 3000000 })
+      mockDashInstance.getActiveStream.mockReturnValue({ getHasVideoTrack: () => true, getHasAudioTrack: () => true })
 
       dispatchDashEvent(dashjsMediaPlayerEvents.STREAM_INITIALIZED)
 
@@ -1650,6 +1651,7 @@ describe("Media Source Extensions Playback Strategy", () => {
 
       mockDashInstance.isReady.mockReturnValue(true)
       mockDashInstance.getTopBitrateInfoFor.mockReturnValue({ qualityIndex: 2, bitrate: 3000000 })
+      mockDashInstance.getActiveStream.mockReturnValue({ getHasVideoTrack: () => true, getHasAudioTrack: () => true })
 
       dispatchDashEvent(dashjsMediaPlayerEvents.STREAM_INITIALIZED)
 
@@ -1674,6 +1676,7 @@ describe("Media Source Extensions Playback Strategy", () => {
 
       mockDashInstance.isReady.mockReturnValue(true)
       mockDashInstance.getTopBitrateInfoFor.mockReturnValue({ qualityIndex: 2, bitrate: 3000000 })
+      mockDashInstance.getActiveStream.mockReturnValue({ getHasVideoTrack: () => true, getHasAudioTrack: () => true })
 
       dispatchDashEvent(dashjsMediaPlayerEvents.STREAM_INITIALIZED)
 
@@ -1698,6 +1701,7 @@ describe("Media Source Extensions Playback Strategy", () => {
 
       mockDashInstance.isReady.mockReturnValue(true)
       mockDashInstance.getTopBitrateInfoFor.mockReturnValue({ qualityIndex: 2, bitrate: 3000000 })
+      mockDashInstance.getActiveStream.mockReturnValue({ getHasVideoTrack: () => true, getHasAudioTrack: () => true })
 
       dispatchDashEvent(dashjsMediaPlayerEvents.STREAM_INITIALIZED)
 

Original file line number	Diff line number	Diff line change
`@@ -327,13 +327,15 @@ function MSEStrategy(`
`327`	`327`	`mediaPlayer.setMediaDuration(Number.MAX_SAFE_INTEGER)`
`328`	`328`	`}`
`329`	`329`
`330`		`- if (mediaKind === MediaKinds.VIDEO) {`
	`330`	`+ if (mediaPlayer.getActiveStream()?.getHasVideoTrack()) {`
`331`	`331`	`dispatchDownloadQualityChangeForKind(MediaKinds.VIDEO)`
`332`	`332`	`dispatchMaxQualityChangeForKind(MediaKinds.VIDEO)`
`333`	`333`	`}`
`334`	`334`
`335`		`- dispatchMaxQualityChangeForKind(MediaKinds.AUDIO)`
`336`		`- dispatchDownloadQualityChangeForKind(MediaKinds.AUDIO)`
	`335`	`+ if (mediaPlayer.getActiveStream()?.getHasAudioTrack()) {`
	`336`	`+ dispatchMaxQualityChangeForKind(MediaKinds.AUDIO)`
	`337`	`+ dispatchDownloadQualityChangeForKind(MediaKinds.AUDIO)`
	`338`	`+ }`
`337`	`339`
`338`	`340`	`emitPlayerInfo()`
`339`	`341`	`}`