fix missing channel_id in slack action

Author: geoffhouse

.github/actions/slack-run-start/action.yml

@@ -14,10 +14,10 @@ inputs:
 outputs:
     channel_id:
         description: Slack channel id for the posted message.
-        value: ${{ steps.post.outputs.channel_id }}
+        value: ${{ steps.extract.outputs.channel_id }}
     ts:
         description: Slack message timestamp for updates.
-        value: ${{ steps.post.outputs.ts }}
+        value: ${{ steps.extract.outputs.ts }}
 
 runs:
     using: composite
@@ -38,3 +38,26 @@ runs:
                   attachments:
                     - color: "${{ inputs.running_color }}"
                       text: "${{ inputs.message_prefix }}: <${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}|${{ github.workflow }}> started at ${{ steps.start-time.outputs.value }}"
+
+        - name: Extract message identifiers
+          id: extract
+          shell: bash
+          env:
+              SLACK_RESPONSE: ${{ steps.post.outputs.response }}
+              SLACK_TS: ${{ steps.post.outputs.ts }}
+              SLACK_CHANNEL_ID: ${{ steps.post.outputs.channel_id }}
+          run: |
+              ts="$SLACK_TS"
+              channel_id="$SLACK_CHANNEL_ID"
+
+              if [[ -n "$SLACK_RESPONSE" && "$SLACK_RESPONSE" != "null" ]]; then
+                  if [[ -z "$ts" ]]; then
+                      ts=$(echo "$SLACK_RESPONSE" | jq -r '.ts // empty')
+                  fi
+                  if [[ -z "$channel_id" ]]; then
+                      channel_id=$(echo "$SLACK_RESPONSE" | jq -r '.channel_id // .channel // empty')
+                  fi
+              fi
+
+              echo "ts=$ts" >> "$GITHUB_OUTPUT"
+              echo "channel_id=$channel_id" >> "$GITHUB_OUTPUT"

.github/workflows/deploy.yml

@@ -133,7 +133,7 @@ jobs:
                       uk.co.bbc.bug.build.commit=${{ github.sha }}
 
             - name: update slack message
-              if: ${{ always() && steps.slack-start.outputs.ts != '' }}
+              if: ${{ always() && steps.slack-start.outputs.ts != '' && steps.slack-start.outputs.channel_id != '' }}
               uses: ./.github/actions/slack-run-finish
               with:
                   channel_id: ${{ steps.slack-start.outputs.channel_id }}

.github/workflows/documentation.yml

@@ -143,7 +143,7 @@ jobs:
 
     slack-finish:
         name: Slack final status
-        if: ${{ always() && needs.slack-start.result == 'success' && needs.slack-start.outputs.ts != '' }}
+        if: ${{ always() && needs.slack-start.result == 'success' && needs.slack-start.outputs.ts != '' && needs.slack-start.outputs.channel_id != '' }}
         needs:
             - slack-start
             - codespell

.github/workflows/test-bug-client.yml

@@ -48,7 +48,7 @@ jobs:
             - run: cd src/client && npm run build --if-present
 
             - name: update slack message
-              if: ${{ always() && steps.slack-start.outputs.ts != '' }}
+              if: ${{ always() && steps.slack-start.outputs.ts != '' && steps.slack-start.outputs.channel_id != '' }}
               uses: ./.github/actions/slack-run-finish
               with:
                   channel_id: ${{ steps.slack-start.outputs.channel_id }}

.github/workflows/test-bug-server.yml

@@ -49,7 +49,7 @@ jobs:
               run: npm run test:server
 
             - name: update slack message
-              if: ${{ always() && steps.slack-start.outputs.ts != '' }}
+              if: ${{ always() && steps.slack-start.outputs.ts != '' && steps.slack-start.outputs.channel_id != '' }}
               uses: ./.github/actions/slack-run-finish
               with:
                   channel_id: ${{ steps.slack-start.outputs.channel_id }}

.github/workflows/test-module-container.yml

@@ -219,7 +219,7 @@ jobs:
 
     slack-finish:
         name: Slack final status
-        if: ${{ always() && needs.slack-start.result == 'success' && needs.slack-start.outputs.ts != '' }}
+        if: ${{ always() && needs.slack-start.result == 'success' && needs.slack-start.outputs.ts != '' && needs.slack-start.outputs.channel_id != '' }}
         needs:
             - slack-start
             - discover-modules

.github/workflows/versioning.yml

@@ -138,7 +138,7 @@ jobs:
 
     slack-finish:
         name: Slack final status
-        if: ${{ always() && needs.slack-start.outputs.ts != '' }}
+        if: ${{ always() && needs.slack-start.outputs.ts != '' && needs.slack-start.outputs.channel_id != '' }}
         needs:
             - slack-start
             - verify-tests