refactor: per comments review

Author: MeriemMechri

.github/workflows/simorgh-unit-tests.yml

@@ -36,8 +36,6 @@ jobs:
         if: steps.cache.ohutputs.cache-hit != 'true'
         run: |
           rm -rf node_modules
-          git config --global user.email "DESimorghMaintainers@bbc.co.uk"
-          git config --global user.name "ws-simorgh-unified-framework"
           git config --global url.https://${{ secrets.WS_UTF_AUTH }}@github.com/.insteadOf https://github.com/
           ./scripts/installNodeModules.sh
 

ws-nextjs-app/package.json

@@ -48,6 +48,7 @@
   },
   "dependencies": {
     "@bbc/unified-web-e2e-framework": "github:bbc/unified-web-e2e-framework#v2.1.8",
+    "@playwright/test": "^1.52.0",
     "next": "16.1.7",
     "sharp": "0.34.5"
   }

ws-nextjs-app/playwright/specs/homePage.spec.ts

@@ -1,12 +1,11 @@
 /* eslint-disable cypress/no-async-tests */
-import { test, expect } from '@playwright/test';
+import { test, expect } from '@bbc/unified-web-e2e-framework';
 import runUrlValidationTest from '../support/helpers/runUrlValidationTest';
 
 const testSuites = [
   {
     path: '/arabic',
     service: 'arabic',
-    variant: undefined,
   },
   {
     path: '/dari',

ws-nextjs-app/playwright/specs/setupCheck.spec.ts

@@ -1,10 +1,10 @@
-// import { test, expect } from '@bbc/unified-web-e2e-framework';
+/* eslint-disable cypress/no-async-tests */
+import { test, expect } from '@bbc/unified-web-e2e-framework';
 
-// test('Verify page title', async ({ page }) => {
-//   await page.goto('https://www.bbc.co.uk/');
-//   expect(await page.title()).toBe('BBC - Home');
-// });
-import { test, expect } from '@playwright/test';
+test('Verify page title', async ({ page }) => {
+  await page.goto('https://www.bbc.co.uk/');
+  expect(await page.title()).toBe('BBC - Home');
+});
 
 test.describe('Home Page - Arabic', () => {
   test('should load and display expected content', async ({ page }) => {

yarn.lock

@@ -5092,6 +5092,17 @@ __metadata:
   languageName: node
   linkType: hard
 
+"@playwright/test@npm:^1.52.0":
+  version: 1.58.2
+  resolution: "@playwright/test@npm:1.58.2"
+  dependencies:
+    playwright: "npm:1.58.2"
+  bin:
+    playwright: cli.js
+  checksum: 10/58bf90139280a0235eeeb6049e9fb4db6425e98be1bf0cc17913b068eef616cf67be57bfb36dc4cb56bcf116f498ffd0225c4916e85db404b343ea6c5efdae13
+  languageName: node
+  linkType: hard
+
 "@polka/url@npm:^1.0.0-next.24":
   version: 1.0.0-next.29
   resolution: "@polka/url@npm:1.0.0-next.29"
@@ -11615,6 +11626,16 @@ __metadata:
   languageName: node
   linkType: hard
 
+"fsevents@npm:2.3.2":
+  version: 2.3.2
+  resolution: "fsevents@npm:2.3.2"
+  dependencies:
+    node-gyp: "npm:latest"
+  checksum: 10/6b5b6f5692372446ff81cf9501c76e3e0459a4852b3b5f1fc72c103198c125a6b8c72f5f166bdd76ffb2fca261e7f6ee5565daf80dca6e571e55bcc589cc1256
+  conditions: os=darwin
+  languageName: node
+  linkType: hard
+
 "fsevents@npm:^2.3.3, fsevents@npm:~2.3.2":
   version: 2.3.3
   resolution: "fsevents@npm:2.3.3"
@@ -11625,6 +11646,15 @@ __metadata:
   languageName: node
   linkType: hard
 
+"fsevents@patch:fsevents@npm%3A2.3.2#optional!builtin<compat/fsevents>":
+  version: 2.3.2
+  resolution: "fsevents@patch:fsevents@npm%3A2.3.2#optional!builtin<compat/fsevents>::version=2.3.2&hash=df0bf1"
+  dependencies:
+    node-gyp: "npm:latest"
+  conditions: os=darwin
+  languageName: node
+  linkType: hard
+
 "fsevents@patch:fsevents@npm%3A^2.3.3#optional!builtin<compat/fsevents>, fsevents@patch:fsevents@npm%3A~2.3.2#optional!builtin<compat/fsevents>":
   version: 2.3.3
   resolution: "fsevents@patch:fsevents@npm%3A2.3.3#optional!builtin<compat/fsevents>::version=2.3.3&hash=df0bf1"
@@ -15918,6 +15948,30 @@ __metadata:
   languageName: node
   linkType: hard
 
+"playwright-core@npm:1.58.2":
+  version: 1.58.2
+  resolution: "playwright-core@npm:1.58.2"
+  bin:
+    playwright-core: cli.js
+  checksum: 10/8a98fcf122167e8703d525db2252de0e3da4ab9110ab6ea9951247e52d846310eb25ea2c805e1b7ccb54b4010c44e5adc3a76aae6da02f34324ccc3e76683bb1
+  languageName: node
+  linkType: hard
+
+"playwright@npm:1.58.2":
+  version: 1.58.2
+  resolution: "playwright@npm:1.58.2"
+  dependencies:
+    fsevents: "npm:2.3.2"
+    playwright-core: "npm:1.58.2"
+  dependenciesMeta:
+    fsevents:
+      optional: true
+  bin:
+    playwright: cli.js
+  checksum: 10/d89d6c8a32388911b9aff9ee0f1a90076219f15c804f2b287db048b9e9cde182aea3131fac1959051d25189ed4218ec4272b137c83cd7f9cd24781cbc77edd86
+  languageName: node
+  linkType: hard
+
 "please-upgrade-node@npm:^3.2.0":
   version: 3.2.0
   resolution: "please-upgrade-node@npm:3.2.0"
@@ -17629,6 +17683,7 @@ __metadata:
     "@cypress/webpack-preprocessor": "npm:7.0.1"
     "@jest/environment": "npm:30.2.0"
     "@jest/types": "npm:30.2.0"
+    "@playwright/test": "npm:^1.52.0"
     "@swc/core": "npm:1.15.11"
     "@testing-library/jest-dom": "npm:6.9.1"
     "@testing-library/react": "npm:16.3.1"