Skip to content

Commit 9cfb457

Browse files
committed
iOS: update patch
Remove the previous workaround for BrowserEngine. This should fix the following error: ld64.lld: error: undefined symbol: be_memory_inline_jit_restrict_rwx_to_rw_with_witness_impl Disable BrowserEngineCore JIT on Catalyst This should fix the following error: error: 'be_memory_inline_jit_restrict_rwx_to_rx_with_witness' is unavailable: not available on macCatalyst These errors were likely triggered by the recent upgrade to XCode 26.0
1 parent 488b5dc commit 9cfb457

1 file changed

Lines changed: 11 additions & 16 deletions

File tree

patches/ios/v8.patch

Lines changed: 11 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,12 @@
1-
diff --git a/BUILD.gn b/BUILD.gn
2-
index 1e3f0181dfb..977ff43a9f6 100644
3-
--- a/BUILD.gn
4-
+++ b/BUILD.gn
5-
@@ -4939,12 +4939,6 @@ v8_header_set("v8_internal_headers") {
1+
diff --git a/src/base/build_config.h b/src/base/build_config.h
2+
index ee745539dfd..188f8d8c6de 100644
3+
--- a/src/base/build_config.h
4+
+++ b/src/base/build_config.h
5+
@@ -45,6 +45,7 @@
66

7-
frameworks = []
8-
9-
- # BrowserEngineKit only exists on iOS itself, not on tvOS and other
10-
- # iOS-derived platforms, so we need to check `target_platform` here.
11-
- if (is_ios && target_platform == "iphoneos") {
12-
- frameworks += [ "BrowserEngineKit.framework" ]
13-
- }
14-
-
15-
public_deps = [
16-
":torque_runtime_support",
17-
":v8_flags",
7+
// BrowserEngineCore JIT write protect is only available on iOS 17.4 and later.
8+
#if defined(V8_HOST_ARCH_ARM64) && defined(V8_OS_IOS) && \
9+
+ !defined(TARGET_OS_MACCATALYST) && \
10+
defined(__IPHONE_17_4) && \
11+
__IPHONE_OS_VERSION_MIN_REQUIRED >= __IPHONE_17_4
12+
#define V8_HAS_BECORE_JIT_WRITE_PROTECT 1

0 commit comments

Comments
 (0)