Merge pull request #514 from presidentJFK/ignoreArgumentErrorForSortInQueryMapper

Ignore argument error for sort in query mapper

Author: davidbegin

lib/webmock/util/query_mapper.rb

@@ -196,7 +196,11 @@ def values_to_query(new_query_values, options = {})
           end
           # Useful default for OAuth and caching.
           # Only to be used for non-Array inputs. Arrays should preserve order.
-          new_query_values.sort!
+          begin
+            new_query_values.sort! # may raise for non-comparable values
+          rescue NoMethodError, ArgumentError
+            # ignore
+          end
         end
 
         buffer = ''

spec/unit/util/query_mapper_spec.rb

@@ -93,16 +93,23 @@
   end
 
   it 'converts array values, vice versa' do
-    query = "one%5B%5D=1&one%5B%5D=2"
+    query = "one%5B%5D=1&one%5B%5D=2" # one[]=1&one[]=2
     values = {"one" => ["1","2"]}
     expect(subject.values_to_query values).to eq query
     expect(subject.query_to_values query).to eq values
   end
 
   it 'converts hash values, vice versa' do
-    query = "one%5Ba%5D=1&one%5Bb%5D=2"
+    query = "one%5Ba%5D=1&one%5Bb%5D=2" # one[a]=1&one[b]=2
     values = {"one" => {"a" => "1", "b" => "2"}}
     expect(subject.values_to_query values).to eq query
     expect(subject.query_to_values query).to eq values
   end
+
+  it 'converts complex nested values, vice versa' do
+    query = "one%5B%5D[foo]=bar&one%5B%5D[zoo]=car" # one[][foo]=bar&one[][zoo]=car
+    values = {"one" => [{"foo" => "bar"}, {"zoo" => "car"}]}
+    expect(subject.values_to_query values).to eq query
+    expect(subject.query_to_values query).to eq values
+  end
 end