Commit 8e8327c
committed
Provide a default host header to make request as valid as possible
While working on this sinatra/sinatra#2053 in
our project. I noticed than when using Webmock, sinatra logs and
especially the enforced rack-protection were showing this kind of logs:
```
D, [2024-11-22T13:05:16.798156 #26673] DEBUG -- : Rack::Protection::HostAuthorization @all_permitted_hosts=[".company.com"] @permitted_hosts=["company.com"] @domain_hosts=[/\A(?-mix:[a-z0-9\-.]+)company\.com\z/i] @ip_hosts=[] origin_host="" forwarded_host=nil
```
As you can see, `origin_host` is empty, because the header is missing.
When not using webmock, we fallback on `net/http` host header setup.
https://github.com/ruby/net-http/blob/cfbbb50c931a78fc2b5c731b9abeda161e1dfdd1/lib/net/http.rb#L24821 parent 50bb349 commit 8e8327c
1 file changed
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
271 | 271 | | |
272 | 272 | | |
273 | 273 | | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
274 | 278 | | |
275 | 279 | | |
276 | 280 | | |
| |||
0 commit comments