Skip to content

Commit 0520ebc

Browse files
committed
minor refactor
1 parent c99895d commit 0520ebc

File tree

1 file changed

+19
-9
lines changed

1 file changed

+19
-9
lines changed

pg/src/test/java/org/bouncycastle/openpgp/test/LegacyEd448KeyPairTest.java

+19-9
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,26 @@
11
package org.bouncycastle.openpgp.test;
22

3-
import org.bouncycastle.bcpg.*;
3+
import java.io.IOException;
4+
import java.security.InvalidAlgorithmParameterException;
5+
import java.security.KeyPair;
6+
import java.security.KeyPairGenerator;
7+
import java.security.NoSuchAlgorithmException;
8+
import java.security.SecureRandom;
9+
import java.util.Date;
10+
11+
import org.bouncycastle.bcpg.EdDSAPublicBCPGKey;
12+
import org.bouncycastle.bcpg.EdSecretBCPGKey;
13+
import org.bouncycastle.bcpg.HashAlgorithmTags;
14+
import org.bouncycastle.bcpg.PublicKeyAlgorithmTags;
415
import org.bouncycastle.crypto.AsymmetricCipherKeyPair;
516
import org.bouncycastle.crypto.generators.Ed448KeyPairGenerator;
617
import org.bouncycastle.crypto.params.Ed448KeyGenerationParameters;
718
import org.bouncycastle.jcajce.spec.EdDSAParameterSpec;
819
import org.bouncycastle.jce.provider.BouncyCastleProvider;
9-
import org.bouncycastle.openpgp.*;
20+
import org.bouncycastle.openpgp.PGPException;
21+
import org.bouncycastle.openpgp.PGPKeyPair;
22+
import org.bouncycastle.openpgp.PGPSignature;
23+
import org.bouncycastle.openpgp.PGPSignatureGenerator;
1024
import org.bouncycastle.openpgp.operator.PGPContentSignerBuilder;
1125
import org.bouncycastle.openpgp.operator.PGPContentVerifierBuilderProvider;
1226
import org.bouncycastle.openpgp.operator.bc.BcPGPContentSignerBuilder;
@@ -15,11 +29,7 @@
1529
import org.bouncycastle.openpgp.operator.jcajce.JcaPGPContentSignerBuilder;
1630
import org.bouncycastle.openpgp.operator.jcajce.JcaPGPContentVerifierBuilderProvider;
1731
import org.bouncycastle.openpgp.operator.jcajce.JcaPGPKeyPair;
18-
19-
import java.io.IOException;
20-
import java.nio.charset.StandardCharsets;
21-
import java.security.*;
22-
import java.util.Date;
32+
import org.bouncycastle.util.Strings;
2333

2434
public class LegacyEd448KeyPairTest
2535
extends AbstractPgpKeyPairTest
@@ -49,7 +59,7 @@ private void testV4SigningVerificationWithJcaKey()
4959
KeyPair kp = gen.generateKeyPair();
5060
PGPKeyPair keyPair = new JcaPGPKeyPair(PublicKeyAlgorithmTags.EDDSA_LEGACY, kp, date);
5161

52-
byte[] data = "Hello, World!\n".getBytes(StandardCharsets.UTF_8);
62+
byte[] data = Strings.toByteArray("Hello, World!\n");
5363

5464
PGPContentSignerBuilder contSigBuilder = new JcaPGPContentSignerBuilder(
5565
keyPair.getPublicKey().getAlgorithm(),
@@ -76,7 +86,7 @@ private void testV4SigningVerificationWithBcKey()
7686
AsymmetricCipherKeyPair kp = gen.generateKeyPair();
7787
BcPGPKeyPair keyPair = new BcPGPKeyPair(PublicKeyAlgorithmTags.EDDSA_LEGACY, kp, date);
7888

79-
byte[] data = "Hello, World!\n".getBytes(StandardCharsets.UTF_8);
89+
byte[] data = Strings.toByteArray("Hello, World!\n");
8090

8191
PGPContentSignerBuilder contSigBuilder = new BcPGPContentSignerBuilder(
8292
keyPair.getPublicKey().getAlgorithm(),

0 commit comments

Comments
 (0)