DBC22-4971: fixed label consistency between route and details panel

Author: ray-oxd

src/backend/apps/authentication/views.py

@@ -150,7 +150,7 @@ def get_queryset(self):
     def create(self, request, *args, **kwargs):
         # add validation for duplicate route name
         label = request.data.get('label', None)
-        if label is not None:
+        if label is not None and label != '':
             existing = self.request.user.routes.filter(label=label).first()
             if existing is not None:
                 return Response({'code': 'duplicate_name'}, status=status.HTTP_400_BAD_REQUEST)

src/frontend/src/Components/routing/RouteDetails.js

@@ -422,7 +422,7 @@ export default function RouteDetails(props) {
   /* Rendering */
   // Subcomponents
   const getDefaultLabel = (isPanel) => {
-    if (isPanel) {
+    if (isPanel && !route.id) {
       return 'Route ' + (route.criteria === 'fastest' ? 'A' : 'B');
     }
 
@@ -615,8 +615,8 @@ export default function RouteDetails(props) {
             <p className="route-distance">{Math.round(route.distance)} km</p>
           </div>
 
-          {route.label && route.label !== getDefaultLabel() &&
-            <p className="route-alt-name">{getDefaultLabel()}</p>
+          {route.label && route.label !== getDefaultLabel(isPanel) &&
+            <p className="route-alt-name">{getDefaultLabel(isPanel)}</p>
           }
         </div>
 

src/frontend/src/Components/routing/RouteObjectList.js

@@ -203,7 +203,11 @@ export default function RouteObjectList(props) {
 
   /* Rendering */
   // Subcomponents
-  const getDefaultLabel = () => {
+  const getDefaultLabel = (isPanel) => {
+    if (isPanel && !selectedRoute.id) {
+      return 'Route ' + (selectedRoute.criteria === 'fastest' ? 'A' : 'B');
+    }
+
     if (selectedRoute.start && selectedRoute.end) {
       return selectedRoute.start + ' to ' + selectedRoute.end;
     }
@@ -443,12 +447,12 @@ export default function RouteObjectList(props) {
           <div className="route-name-and-distance">
             <h4
               className="route-name">
-                {selectedRoute.label ? selectedRoute.label : `Route ${(selectedRoute.criteria === 'fastest') ? 'A' : 'B'}`}
+                {selectedRoute.label ? selectedRoute.label : getDefaultLabel(true)}
               </h4>
             <p className="route-distance">{Math.round(selectedRoute.distance)} km</p>
           </div>
-          {selectedRoute.label &&
-            <p className="route-alt-name">{getDefaultLabel()}</p>
+          {selectedRoute.label && selectedRoute.label !== getDefaultLabel(true) &&
+            <p className="route-alt-name">{getDefaultLabel(true)}</p>
           }
         </div>