Skip to content

Commit f579f26

Browse files
committed
fix: address copilot PR feedback on skill and template
- Remove reference to non-existent TEAM_CHECKLIST.md file - Update template path to use relative markdown link - Replace hardcoded status check names with reference to aggregator pattern in github-actions skill - Fix capitalization: BCGov → BC Gov
1 parent 1fe293b commit f579f26

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

skills/github-repo-setup/SKILL.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,14 @@ Evaluate repository compliance against contractually mandated BC Gov DevOps and
3131
3. **Assess Repo configuration (GitHub API/Git)**:
3232
- Check local git configurations and repository parameters when querying. If online API tools are unavailable, perform manual reasoning on branch naming, rulesets, and pull requests.
3333
4. **Draft the Compliance Scorecard**:
34-
- Compare the findings against the [BCGov DevOps & Dependency Security Standards](https://github.com/bcgov/agent-skills/blob/main/TEAM_CHECKLIST.md) (or `TEAM_CHECKLIST.md`).
35-
- Use the reference template `skills/github-repo-setup/resources/REPORT_TEMPLATE.md` as the format.
34+
- Compare the findings against the BC Gov DevOps & Dependency Security Standards (detailed in the **Rules** section below).
35+
- Use the reference template [REPORT_TEMPLATE.md](./resources/REPORT_TEMPLATE.md) as the format.
3636
5. **Write Report**: Generate `MATURITY_REPORT.md` in the target repository's root directory. The report must be thorough, precise, and state clear, actionable remediation items.
3737

3838
## Rules
3939
- **No-Exemption Policy**: All security vulnerabilities must be remediated regardless of justifications like "trusted environments," "internal access," or "unreachable paths."
4040
- **GitHub Repository Settings**: Enforce Squash Merging Only (uncheck merge/rebase commits). Enable Branch Auto-Cleanup and Always Suggest Updating PR branches.
41-
- **Branch Protection Ruleset**: The `main` branch ruleset must require a PR, at least 1 approval, conversation resolution, linear history, and strict status checks (`Analysis Results`, `PR Results`, `Validate Results`). Block force pushes.
41+
- **Branch Protection Ruleset**: The `main` branch ruleset must require a PR, at least 1 approval, conversation resolution, linear history, and a required status check. Require a single aggregated results check (per [github-actions SKILL](../github-actions/SKILL.md)) and block force pushes.
4242
- **TypeScript Hygiene**: For TypeScript projects, compiler options must enforce strictness:
4343
```json
4444
{
@@ -106,7 +106,7 @@ Always generate a `MATURITY_REPORT.md` file in the root of the audited repositor
106106

107107
## References
108108

109-
- [BC Gov DevOps Standards](https://github.com/bcgov/agent-skills/blob/main/TEAM_CHECKLIST.md) – Baseline compliance requirements.
109+
- [BC Gov DevOps Standards](#rules) – Baseline compliance requirements defined in this skill.
110110
- [BC Gov Renovate Config](https://github.com/bcgov/renovate-config) – Inherited preset configurations for dependency updates.
111111
- [GitHub Branch Protection Rules](https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches) – GitHub documentation on branch rulesets.
112112
- [TypeScript Strict Mode](https://www.typescriptlang.org/tsconfig#strict) – TypeScript compiler documentation for strict checking.

skills/github-repo-setup/resources/REPORT_TEMPLATE.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Repository Compliance & Maturity Assessment
22

3-
This report evaluates compliance against the [BCGov DevOps & Dependency Security Standards](https://github.com/bcgov/agent-skills/blob/main/TEAM_CHECKLIST.md).
3+
This report evaluates compliance against BC Gov DevOps & Dependency Security Standards (see [skill documentation](../SKILL.md) for detailed requirements).
44

55
## Executive Summary
66

@@ -62,7 +62,7 @@ This report evaluates compliance against the [BCGov DevOps & Dependency Security
6262

6363
### 5. Dependency Update Automation
6464
- [ ] **Renovate / Dependabot Configured:**
65-
- [ ] **Pinned Config / Upstream BCGov Configuration extended:**
65+
- [ ] **Pinned Config / Upstream BC Gov Configuration extended:**
6666
- [ ] **Minimum Release Age (7 days):**
6767
- [ ] **Automerge Policies:**
6868
- [ ] **Dependency Dashboard active:**

0 commit comments

Comments
 (0)