Remove unused mime helper and tidy imports

Clean up and refactor several backend files: removed the unused getMimeType helper from hitl-dataset.service.ts; reorganized and reordered imports (document controller, labeling services and tests) to satisfy linting and clarity; adjusted minor formatting (wrapped blobStorage.read argument, wrapped long ApiForbiddenResponse description, and fixed line breaks in tests). Also corrected DTO import order in labeling-conversion-failed-response and small test/controller call formatting. These are non-functional cleanup changes to improve code style and maintainability.

Author: kmandryk

apps/backend-services/src/benchmark/hitl-dataset.service.ts

@@ -452,19 +452,6 @@ export class HitlDatasetService {
 
     return groundTruth;
   }
-
-  private getMimeType(ext: string): string {
-    const mimeTypes: Record<string, string> = {
-      ".pdf": "application/pdf",
-      ".png": "image/png",
-      ".jpg": "image/jpeg",
-      ".jpeg": "image/jpeg",
-      ".tif": "image/tiff",
-      ".tiff": "image/tiff",
-      ".bmp": "image/bmp",
-    };
-    return mimeTypes[ext.toLowerCase()] ?? "application/octet-stream";
-  }
 }
 
 /**

apps/backend-services/src/document/document.controller.ts

@@ -46,10 +46,10 @@ import {
 import { AppLoggerService } from "../logging/app-logger.service";
 import { TemporalClientService } from "../temporal/temporal-client.service";
 import { type DocumentData, DocumentService } from "./document.service";
-import { getContentTypeFromFilename } from "./mime-from-filename";
 import { ApproveDocumentDto } from "./dto/approve-document.dto";
 import { OcrResultResponseDto } from "./dto/ocr-result-response.dto";
 import { UpdateDocumentDto } from "./dto/update-document.dto";
+import { getContentTypeFromFilename } from "./mime-from-filename";
 
 @ApiTags("Documents")
 @Controller("api/documents")
@@ -440,7 +440,9 @@ export class DocumentController {
       payload: { action: "view" },
     });
 
-    const fileBuffer = await this.blobStorage.read(document.normalized_file_path);
+    const fileBuffer = await this.blobStorage.read(
+      document.normalized_file_path,
+    );
 
     res.setHeader("Content-Type", "application/pdf");
     res.setHeader("Content-Disposition", 'inline; filename="document.pdf"');

apps/backend-services/src/document/document.service.spec.ts

@@ -6,9 +6,9 @@ import {
   BLOB_STORAGE,
   BlobStorageInterface,
 } from "../blob-storage/blob-storage.interface";
-import { PdfNormalizationService } from "./pdf-normalization.service";
 import { DocumentService } from "./document.service";
 import { DocumentDbService } from "./document-db.service";
+import { PdfNormalizationService } from "./pdf-normalization.service";
 
 describe("DocumentService", () => {
   let service: DocumentService;

apps/backend-services/src/labeling/dto/labeling-conversion-failed-response.dto.ts

@@ -1,7 +1,7 @@
 import { ApiProperty } from "@nestjs/swagger";
 import {
-  LabelingDocumentResponseDto,
   LabeledDocumentResponseDto,
+  LabelingDocumentResponseDto,
 } from "./labeling-responses.dto";
 
 /** Response body for HTTP 422 when the original blob was stored but normalization to PDF failed. */

apps/backend-services/src/labeling/labeling-ocr.service.spec.ts

@@ -3,14 +3,14 @@ import { HttpService } from "@nestjs/axios";
 import { ConfigService } from "@nestjs/config";
 import { Test, TestingModule } from "@nestjs/testing";
 import { of } from "rxjs";
+import { PdfNormalizationService } from "@/document/pdf-normalization.service";
 import { AppLoggerService } from "@/logging/app-logger.service";
 import { mockAppLogger } from "@/testUtils/mockAppLogger";
 import {
   BLOB_STORAGE,
   BlobStorageInterface,
 } from "../blob-storage/blob-storage.interface";
 import { LabelingFileType, LabelingUploadDto } from "./dto/labeling-upload.dto";
-import { PdfNormalizationService } from "@/document/pdf-normalization.service";
 import { LabelingDocumentDbService } from "./labeling-document-db.service";
 import { LabelingOcrService } from "./labeling-ocr.service";
 

apps/backend-services/src/labeling/labeling-ocr.service.ts

@@ -1,15 +1,15 @@
 import { DocumentStatus, Prisma } from "@generated/client";
-import { BadRequestException, Inject, Injectable } from "@nestjs/common";
 import { HttpService } from "@nestjs/axios";
+import { BadRequestException, Inject, Injectable } from "@nestjs/common";
 import { ConfigService } from "@nestjs/config";
 import { lastValueFrom } from "rxjs";
 import { v4 as uuidv4 } from "uuid";
-import { AppLoggerService } from "@/logging/app-logger.service";
 import { extensionForOriginalBlob } from "@/document/original-blob-key.util";
 import {
   PdfNormalizationError,
   PdfNormalizationService,
 } from "@/document/pdf-normalization.service";
+import { AppLoggerService } from "@/logging/app-logger.service";
 import {
   BLOB_STORAGE,
   BlobStorageInterface,

apps/backend-services/src/labeling/labeling.controller.spec.ts

@@ -364,7 +364,11 @@ describe("LabelingController", () => {
       } as unknown as Request;
       labelingService.getProject.mockResolvedValue(mockProject as any);
       await expect(
-        controller.uploadLabelingDocument("project-1", { ...dto, group_id: "other-group" }, req),
+        controller.uploadLabelingDocument(
+          "project-1",
+          { ...dto, group_id: "other-group" },
+          req,
+        ),
       ).rejects.toThrow(BadRequestException);
       expect(labelingService.uploadLabelingDocument).not.toHaveBeenCalled();
     });

apps/backend-services/src/labeling/labeling.controller.ts

@@ -49,8 +49,8 @@ import {
   CreateFieldDefinitionDto,
   UpdateFieldDefinitionDto,
 } from "./dto/field-definition.dto";
-import { LabelingConversionFailedResponseDto } from "./dto/labeling-conversion-failed-response.dto";
 import { SaveLabelsDto } from "./dto/label.dto";
+import { LabelingConversionFailedResponseDto } from "./dto/labeling-conversion-failed-response.dto";
 import {
   DeleteDocumentResponseDto,
   DeleteResponseDto,

apps/backend-services/src/upload/upload.controller.ts

@@ -56,7 +56,8 @@ export class UploadController {
   @ApiBadRequestResponse({ description: "Invalid input or upload failed" })
   @ApiUnauthorizedResponse({ description: "Not authenticated" })
   @ApiForbiddenResponse({
-    description: "Access denied: not a member of the requested group or insufficient role",
+    description:
+      "Access denied: not a member of the requested group or insufficient role",
   })
   async uploadDocument(
     @Body() uploadDto: UploadDocumentDto,