Merge pull request #2761 from bcgov/develop

Deployment PR - 1718

Author: trslater

.github/workflows/ci.yml

@@ -56,6 +56,6 @@ jobs:
       - uses: actions/setup-node@master
         with:
           node-version: ${{ matrix.node }}
-      - run: npm install
+      - run: npm ci
       - run: npm run build
       - run: npm run test

.github/workflows/coverage.yml

@@ -19,7 +19,7 @@ jobs:
       - uses: actions/setup-node@master
         with:
           node-version: ${{ matrix.node }}
-      - run: npm install
+      - run: npm ci
       - run: npm run build
       - run: npm run test:cov
       - if: matrix.node == '24'
@@ -44,7 +44,7 @@ jobs:
       - uses: actions/setup-node@master
         with:
           node-version: ${{ matrix.node }}
-      - run: npm install
+      - run: npm ci
       - run: npm run build
       - run: npm run test:cov
       - if: matrix.node == '24'
@@ -69,7 +69,7 @@ jobs:
       - uses: actions/setup-node@master
         with:
           node-version: ${{ matrix.node }}
-      - run: npm install
+      - run: npm ci
       - run: npm run build
       - run: npm run test:cov
       - if: matrix.node == '24'

e2e/pages/alcs/alcs-login-page.ts

@@ -22,16 +22,13 @@ export class ALCSLoginPage {
   }
 
   async login(username: string, password: string) {
-    // Click IDIR link and wait for navigation to external auth service
-    // Use domcontentloaded since external auth services can be slow
-    await Promise.all([
-      this.page.waitForURL('**/auth/**', { timeout: 30000, waitUntil: 'domcontentloaded' }),
-      this.idirLink.click(),
-    ]);
-
-    // Wait for login form to be ready
-    await this.userIdTextbox.waitFor({ state: 'visible', timeout: 30000 });
-
+    // Click IDIR link - Playwright auto-waits for navigation
+    await this.idirLink.click();
+    
+    // Fill username - Playwright automatically waits for:
+    // - Element to appear after SAML redirects
+    // - Element to be visible, enabled, and stable
+    // - Navigation to complete
     await this.userIdTextbox.fill(username);
     await this.passwordTextbox.fill(password);
     await this.continueButton.click();

e2e/pages/portal/parcels-page.ts

@@ -168,7 +168,7 @@ export class ParcelsPage {
     await this.ownerSaveButton.click();
 
     // Wait for dialog to disappear
-    await this.ownerAddDialog.waitFor({ state: 'hidden', timeout: 5000 });
+    await this.ownerAddDialog.waitFor({ state: 'hidden', timeout: 15000 });
   }
 
   // Actions

e2e/pages/portal/portal-login-page.ts

@@ -22,16 +22,13 @@ export class PortalLoginPage {
   }
 
   async logIn(username: string, password: string) {
-    // Click login and wait for navigation to external auth service
-    // Use domcontentloaded since external auth services can be slow
-    await Promise.all([
-      this.page.waitForURL('**/auth/**', { timeout: 30000, waitUntil: 'domcontentloaded' }),
-      this.loginButton.click(),
-    ]);
-
-    // Wait for login form to be ready
-    await this.userIdTextbox.waitFor({ state: 'visible', timeout: 30000 });
-
+    // Click login button - Playwright auto-waits for navigation
+    await this.loginButton.click();
+    
+    // Fill username - Playwright automatically waits for:
+    // - Element to appear after SAML redirects
+    // - Element to be visible, enabled, and stable
+    // - Navigation to complete
     await this.userIdTextbox.fill(username);
     await this.passwordTextbox.fill(password);
     await this.continueButton.click();

e2e/playwright.config.ts

@@ -32,8 +32,8 @@ export default defineConfig({
     trace: 'on-first-retry',
 
     /* Increase timeouts for external auth services which can be slow */
-    navigationTimeout: 30000,
-    actionTimeout: 30000,
+    navigationTimeout: 60000,
+    actionTimeout: 60000,
   },
 
   /* Configure projects for major browsers */