Merge pull request #2503 from bcgov/2395-add-ownership-documents-to-intake-form-qa-1

2395 QA 1: Auto-assign property to COT

Author: trslater

alcs-frontend/src/app/features/compliance-and-enforcement/details/complaint-referral/complaint-referral.component.html

@@ -15,6 +15,7 @@
     <app-compliance-and-enforcement-documents
       #submissionDocumentsComponent
       [title]="'Complaint/Referral Submission'"
+      [noDocumentsText]="'No Complaint/Referral'"
       [fileNumber]="fileNumber"
       [options]="submissionDocumentOptions"
       [section]="Section.SUBMISSION"

alcs-frontend/src/app/features/compliance-and-enforcement/documents/documents.component.html

@@ -50,6 +50,6 @@ <h3>{{ title }}</h3>
   <tr mat-header-row *matHeaderRowDef="displayedColumns"></tr>
   <tr mat-row *matRowDef="let row; columns: displayedColumns"></tr>
   <tr class="mat-row" *matNoDataRow>
-    <td class="text-center" colspan="6">No Complaint/Referral</td>
+    <td class="text-center" colspan="6">{{ noDocumentsText }}</td>
   </tr>
 </table>

alcs-frontend/src/app/features/compliance-and-enforcement/documents/documents.component.ts

@@ -27,6 +27,7 @@ export class ComplianceAndEnforcementDocumentsComponent implements OnDestroy {
   isSubscribed = false;
 
   @Input() title?: string;
+  @Input() noDocumentsText?: string;
   @Input() fileNumber?: string;
   @Input() options?: DocumentUploadDialogData;
   @Input() section?: Section;

alcs-frontend/src/app/features/compliance-and-enforcement/draft/draft.component.html

@@ -17,6 +17,7 @@ <h3>Overview</h3>
       <app-compliance-and-enforcement-documents
         #submissionDocumentsComponent
         [title]="'Complaint/Referral Submission'"
+        [noDocumentsText]="'No Complaint/Referral'"
         [fileNumber]="fileNumber"
         [options]="submissionDocumentOptions"
         [section]="Section.SUBMISSION"
@@ -36,6 +37,7 @@ <h3>Overview</h3>
       <app-compliance-and-enforcement-documents
         #ownershipDocumentsComponent
         [title]="'Property Ownership Documents'"
+        [noDocumentsText]="'No owner information'"
         [fileNumber]="fileNumber"
         [options]="ownershipDocumentOptions"
         [section]="Section.OWNERSHIP"
@@ -44,11 +46,17 @@ <h3>Overview</h3>
 
     <div class="button-row">
       <div class="left-actions">
-        <button type="button" mat-stroked-button color="warn" (click)="onCancelDiscardClicked()">Cancel & Discard</button>
+        <button type="button" mat-stroked-button color="warn" (click)="onCancelDiscardClicked()">
+          Cancel & Discard
+        </button>
       </div>
       <div class="right-actions">
-        <button type="button" mat-stroked-button color="primary" (click)="onSaveDraftClicked()">Save Draft & Exit</button>
-        <button type="button" mat-flat-button color="primary" (click)="onFinishCreateFileClicked()">Finish & Create File</button>
+        <button type="button" mat-stroked-button color="primary" (click)="onSaveDraftClicked()">
+          Save Draft & Exit
+        </button>
+        <button type="button" mat-flat-button color="primary" (click)="onFinishCreateFileClicked()">
+          Finish & Create File
+        </button>
       </div>
     </div>
   </form>

alcs-frontend/src/app/features/compliance-and-enforcement/draft/draft.component.ts

@@ -72,7 +72,6 @@ export class DraftComponent implements OnInit, AfterViewInit, OnDestroy {
       DOCUMENT_SOURCE.OTHER_AGENCY,
       DOCUMENT_SOURCE.ALC,
     ],
-    defaultDocumentSource: DOCUMENT_SOURCE.ALC,
     allowedDocumentTypes: [
       DOCUMENT_TYPE.CERTIFICATE_OF_TITLE,
       DOCUMENT_TYPE.CORPORATE_SUMMARY,
@@ -236,6 +235,10 @@ export class DraftComponent implements OnInit, AfterViewInit, OnDestroy {
 
     // Watch for property ownership changes to update Crown status
     this.propertyComponent.$changes.pipe(takeUntil(this.$destroy)).subscribe(async (propertyUpdate) => {
+      if (this.ownershipDocumentOptions.fixedParcel) {
+        this.ownershipDocumentOptions.fixedParcel.pid = propertyUpdate.pid ?? undefined;
+      }
+
       if (propertyUpdate.ownershipTypeCode) {
         const wasCrown = this.isPropertyCrown;
         this.isPropertyCrown = propertyUpdate.ownershipTypeCode === 'CRWN';
@@ -262,6 +265,8 @@ export class DraftComponent implements OnInit, AfterViewInit, OnDestroy {
           const properties = await this.complianceAndEnforcementPropertyService.fetchByFileUuid(this.file.uuid);
           this.property = properties[0];
 
+          this.ownershipDocumentOptions.fixedParcel = this.property;
+
           if (this.propertyComponent && this.property) {
             this.propertyComponent.property = this.property;
           }

alcs-frontend/src/app/services/compliance-and-enforcement/property/property.service.ts

@@ -13,7 +13,9 @@ export class ComplianceAndEnforcementPropertyService {
   constructor(private readonly http: HttpClient) {}
 
   async fetchParcels(fileNumber: string): Promise<ComplianceAndEnforcementPropertyDto[]> {
-    return await firstValueFrom(this.http.get<ComplianceAndEnforcementPropertyDto[]>(`${this.url}/${fileNumber}`));
+    return await firstValueFrom(
+      this.http.get<ComplianceAndEnforcementPropertyDto[]>(`${this.url}/${fileNumber}?idType=fileNumber`),
+    );
   }
 
   async fetchByFileUuid(fileUuid: string): Promise<ComplianceAndEnforcementPropertyDto[]> {

alcs-frontend/src/app/shared/document-upload-dialog/document-upload-dialog.component.html

@@ -88,7 +88,7 @@ <h4>{{ title }} Document</h4>
         </mat-select>
       </mat-form-field>
     </div>
-    <div *ngIf="selectableParcels && type.value === DOCUMENT_TYPE.CERTIFICATE_OF_TITLE">
+    <div *ngIf="type.value === DOCUMENT_TYPE.CERTIFICATE_OF_TITLE && !data.fixedParcel && selectableParcels">
       <mat-form-field appearance="outline" class="full-width">
         <mat-label>Associated Parcel</mat-label>
         <mat-select [formControl]="parcelId">

alcs-frontend/src/app/shared/document-upload-dialog/document-upload-dialog.interface.ts

@@ -32,6 +32,7 @@ export interface DocumentUploadDialogData extends DocumentUploadDialogOptions {
   documentService?: DocumentService;
   parcelService?: ParcelFetchingService;
   submissionService?: SubmissionFetchingService;
+  fixedParcel?: SelectableParcelDto;
 }
 
 export interface DecisionService {

services/apps/alcs/src/alcs/compliance-and-enforcement/property/property.controller.ts

@@ -1,4 +1,4 @@
-import { Body, Controller, Delete, Get, Param, Patch, Post, UseGuards } from '@nestjs/common';
+import { Body, Controller, Delete, Get, Param, Patch, Post, Query, UseGuards } from '@nestjs/common';
 import { ApiOAuth2 } from '@nestjs/swagger';
 import * as config from 'config';
 import { RolesGuard } from '../../../common/authorization/roles-guard.service';
@@ -14,10 +14,17 @@ import { DeleteResult } from 'typeorm';
 export class ComplianceAndEnforcementPropertyController {
   constructor(private service: ComplianceAndEnforcementPropertyService) {}
 
-  @Get('/:fileUuid')
+  @Get('/:id')
   @UserRoles(...ROLES_ALLOWED_APPLICATIONS)
-  async fetchParcelsByFileUuid(@Param('fileUuid') fileUuid: string): Promise<ComplianceAndEnforcementPropertyDto[]> {
-    return await this.service.fetchParcelsByFileUuid(fileUuid);
+  async fetchParcelsByid(
+    @Param('id') id: string,
+    @Query('idType') idType?: string,
+  ): Promise<ComplianceAndEnforcementPropertyDto[]> {
+    if (idType === 'fileNumber') {
+      return await this.service.fetchParcels(id);
+    }
+
+    return await this.service.fetchParcelsByFileUuid(id);
   }
 
   @Post('')