Skip to content

Commit 7c9bc81

Browse files
authored
Merge pull request #2499 from bcgov/2416-create-complaint-referral-tab-from-submission-qa-1
2416 QA 1: Fix cancel button, fix overview edit title, add anonymous template
2 parents 77d0818 + 594cc1a commit 7c9bc81

File tree

8 files changed

+57
-38
lines changed

8 files changed

+57
-38
lines changed

alcs-frontend/src/app/features/compliance-and-enforcement/compliance-and-enforcement.module.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ const routes: Routes = [
4646
{
4747
path: ':fileNumber',
4848
component: ComplianceAndEnforcementComponent,
49-
children: detailsRoutes.concat([]),
49+
children: detailsRoutes,
5050
},
5151
{
5252
path: ':fileNumber/draft',

alcs-frontend/src/app/features/compliance-and-enforcement/details/complaint-referral/complaint-referral.component.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,12 @@
2525
<ng-container *ngIf="editing === 'overview'">
2626
<form [formGroup]="form">
2727
<section class="form-section">
28+
<h3>Overview / Referral > Edit Overview</h3>
2829
<app-compliance-and-enforcement-overview #overviewComponent [parentForm]="form" [file]="file" />
2930
</section>
3031

3132
<div class="button-container">
32-
<a mat-flat-button [routerLink]="'../..'">Cancel</a>
33+
<a mat-stroked-button color="warn" [routerLink]="'../..'">Cancel</a>
3334
<button mat-flat-button color="primary" (click)="save()">Save</button>
3435
</div>
3536
</form>

alcs-frontend/src/app/features/compliance-and-enforcement/details/complaint-referral/complaint-referral.component.scss

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,3 +34,9 @@ section.file-section {
3434
font-weight: 700 !important;
3535
text-transform: uppercase;
3636
}
37+
38+
a[mat-stroked-button] {
39+
font-size: 14px !important;
40+
font-weight: 700 !important;
41+
text-transform: uppercase;
42+
}

alcs-frontend/src/app/features/compliance-and-enforcement/details/complaint-referral/overview/overview.component.scss

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
.inset {
88
display: grid;
99
grid-template-columns: 1fr 1fr;
10-
gap: 16px;
10+
gap: 24px;
1111

1212
background-color: colors.$grey-light;
1313
padding: 24px;
@@ -16,7 +16,6 @@
1616

1717
.field {
1818
width: 100%;
19-
margin-bottom: 16px;
2019

2120
&.full-width {
2221
grid-column: span 2;

alcs-frontend/src/app/features/compliance-and-enforcement/details/complaint-referral/submitters/submitters.component.html

Lines changed: 38 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -5,41 +5,51 @@ <h3>Submitters</h3>
55
</ng-template>
66

77
<div class="inset" *ngFor="let submitter of submitters">
8-
<div class="header">
9-
<h4>{{ submitter.name }}</h4>
8+
<ng-container *ngIf="!submitter.isAnonymous; else anonymous">
9+
<div class="header">
10+
<h4>{{ submitter.name }}</h4>
1011

11-
<div class="date-added">Added: {{ formatDate(submitter.dateAdded) }}</div>
12-
</div>
12+
<div class="date-added">Added: {{ formatDate(submitter.dateAdded) }}</div>
13+
</div>
1314

14-
<div class="field">
15-
<div class="field-heading">Email</div>
15+
<div class="field">
16+
<div class="field-heading">Email</div>
1617

17-
<ng-container *ngIf="submitter.email; else noData">
18-
{{ submitter.email }}
19-
</ng-container>
20-
</div>
18+
<ng-container *ngIf="submitter.email; else noData">
19+
{{ submitter.email }}
20+
</ng-container>
21+
</div>
2122

22-
<div class="field">
23-
<div class="field-heading">Telephone</div>
23+
<div class="field">
24+
<div class="field-heading">Telephone</div>
2425

25-
<ng-container *ngIf="submitter.telephoneNumber; else noData">
26-
{{ submitter.telephoneNumber | mask: '(000) 000-0000' }}
27-
</ng-container>
28-
</div>
26+
<ng-container *ngIf="submitter.telephoneNumber; else noData">
27+
{{ submitter.telephoneNumber | mask: '(000) 000-0000' }}
28+
</ng-container>
29+
</div>
2930

30-
<div class="field">
31-
<div class="field-heading">Affiliation</div>
31+
<div class="field">
32+
<div class="field-heading">Affiliation</div>
3233

33-
<ng-container *ngIf="submitter.affiliation; else noData">
34-
{{ submitter.affiliation }}
35-
</ng-container>
36-
</div>
34+
<ng-container *ngIf="submitter.affiliation; else noData">
35+
{{ submitter.affiliation }}
36+
</ng-container>
37+
</div>
3738

38-
<div class="field">
39-
<div class="field-heading">Additional Contact Information</div>
39+
<div class="field">
40+
<div class="field-heading">Additional Contact Information</div>
4041

41-
<ng-container *ngIf="submitter.additionalContactInformation; else noData">
42-
{{ submitter.additionalContactInformation }}
43-
</ng-container>
44-
</div>
42+
<ng-container *ngIf="submitter.additionalContactInformation; else noData">
43+
{{ submitter.additionalContactInformation }}
44+
</ng-container>
45+
</div>
46+
</ng-container>
47+
48+
<ng-template #anonymous>
49+
<div class="header">
50+
<h4>Anonymous</h4>
51+
52+
<div class="date-added">Added: {{ formatDate(submitter.dateAdded) }}</div>
53+
</div>
54+
</ng-template>
4555
</div>

alcs-frontend/src/app/features/compliance-and-enforcement/details/complaint-referral/submitters/submitters.component.scss

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
.inset {
88
display: grid;
99
grid-template-columns: 1fr 1fr;
10-
gap: 16px;
10+
gap: 24px;
1111

1212
background-color: colors.$grey-light;
1313
padding: 24px;
@@ -18,13 +18,15 @@
1818
justify-content: space-between;
1919
align-items: center;
2020
grid-column: span 2;
21-
margin-bottom: 24px;
21+
22+
// &:has(+ *) {
23+
// margin-bottom: 24px;
24+
// }
2225
}
2326
}
2427

2528
.field {
2629
width: 100%;
27-
margin-bottom: 16px;
2830

2931
&.full-width {
3032
grid-column: span 2;

alcs-frontend/src/app/features/compliance-and-enforcement/draft/draft.component.html

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@ <h2>C&E File ID: {{ file?.fileNumber }}</h2>
33

44
<form [formGroup]="form">
55
<section class="form-section">
6-
<app-compliance-and-enforcement-overview #overviewComponent [parentForm]="form" [file]="file" />
6+
<div>
7+
<h3>Overview</h3>
8+
<app-compliance-and-enforcement-overview #overviewComponent [parentForm]="form" [file]="file" />
9+
</div>
710
<app-compliance-and-enforcement-submitter
811
#submitterComponent
912
[parentForm]="form"

alcs-frontend/src/app/features/compliance-and-enforcement/overview/overview.component.html

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
<h3>Overview</h3>
2-
31
<form [formGroup]="form">
42
<mat-form-field appearance="outline" class="date-picker">
53
<mat-label>Date Submitted</mat-label>

0 commit comments

Comments
 (0)