Code Scanning Fixes (#2637)

* fix: sonar cloud code check fix in frontend and backend

* chore: added new sonarcloud project keys

* chore: updated sonar timeout on frontend

Author: PaulGreywal

.github/workflows/sonarcloud.yml

@@ -40,14 +40,13 @@ jobs:
         with:
           commands: |
             npm ci
-            npm run lint
             npm run test:cov
           dir: services
           node_version: "22"
           sonar_args: >
             -Dsonar.exclusions=**/coverage/**,**/node_modules/**,**/*spec.ts
             -Dsonar.organization=bcgov-sonarcloud
-            -Dsonar.projectKey=bcgov_alcs
+            -Dsonar.projectKey=bcgov-alcs-services
             -Dsonar.sources=apps,libs
             -Dsonar.tests.inclusions=**/*spec.ts
             -Dsonar.javascript.lcov.reportPaths=./coverage/lcov.info
@@ -58,22 +57,21 @@ jobs:
     name: ALCS Frontend Tests
     if: (! github.event.pull_request.draft)
     runs-on: ubuntu-24.04
-    timeout-minutes: 5
+    timeout-minutes: 10
     steps:
       - uses: bcgov/action-test-and-analyse@51b50be3bb2522e480ed8eab72735612deff7f15 # v1.4.0
         env:
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
         with:
           commands: |
             npm ci
-            npm run lint
             npm run test:cov
           dir: alcs-frontend
           node_version: "22"
           sonar_args: >
             -Dsonar.exclusions=**/coverage/**,**/node_modules/**,**/*spec.ts
             -Dsonar.organization=bcgov-sonarcloud
-            -Dsonar.projectKey=bcgov_alcs
+            -Dsonar.projectKey=bcgov-alcs-frontend
             -Dsonar.sources=src
             -Dsonar.tests.inclusions=**/*spec.ts
             -Dsonar.javascript.lcov.reportPaths=./coverage/lcov.info
@@ -92,14 +90,13 @@ jobs:
         with:
           commands: |
             npm ci
-            npm run lint
             npm run test:cov
           dir: portal-frontend
           node_version: "22"
           sonar_args: >
             -Dsonar.exclusions=**/coverage/**,**/node_modules/**,**/*spec.ts
             -Dsonar.organization=bcgov-sonarcloud
-            -Dsonar.projectKey=bcgov_alcs
+            -Dsonar.projectKey=bcgov-alcs-portal-frontend
             -Dsonar.sources=src
             -Dsonar.tests.inclusions=**/*spec.ts
             -Dsonar.javascript.lcov.reportPaths=./coverage/lcov.info

portal-frontend/.eslintrc.json

@@ -0,0 +1,41 @@
+{
+  "root": true,
+  "ignorePatterns": ["projects/**/*"],
+  "overrides": [
+    {
+      "files": ["*.ts"],
+      "parserOptions": {
+        "project": ["tsconfig.json"],
+        "createDefaultProgram": true
+      },
+      "extends": ["plugin:@angular-eslint/recommended", "plugin:@angular-eslint/template/process-inline-templates"],
+      "rules": {
+        "@angular-eslint/directive-selector": [
+          "error",
+          {
+            "type": "attribute",
+            "prefix": "app",
+            "style": "camelCase"
+          }
+        ],
+        "@angular-eslint/component-selector": [
+          "error",
+          {
+            "type": "element",
+            "prefix": "app",
+            "style": "kebab-case"
+          }
+        ]
+      }
+    },
+    {
+      "files": ["*.html"],
+      "extends": ["plugin:@angular-eslint/template/recommended"],
+      "rules": {
+        "@angular-eslint/template/no-positive-tabindex": 1,
+        "@angular-eslint/template/click-events-have-key-events": 1,
+        "@angular-eslint/template/mouse-events-have-key-events": 1
+      }
+    }
+  ]
+}