Skip to content

Commit 7d65bcb

Browse files
authored
Merge pull request #2786 from bcgov/2649-check-for-and-fix-high-severity-issues-before-test-cut-4
2649: Use latest NPM for runtime API image
2 parents ac776db + c0130f6 commit 7d65bcb

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ jobs:
4848
strategy:
4949
matrix:
5050
platform: [ubuntu-latest]
51-
node: ["20"]
51+
node: ["24"]
5252
name: API Tests - ${{ matrix.node }}/${{ matrix.platform }}
5353
runs-on: ${{ matrix.platform }}
5454
steps:

.github/workflows/sonarcloud.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ jobs:
4242
npm ci
4343
npm run test:cov
4444
dir: services
45-
node_version: "20"
45+
node_version: "24"
4646
sonar_args: >
4747
-Dsonar.exclusions=**/coverage/**,**/node_modules/**,**/*spec.ts
4848
-Dsonar.organization=bcgov-sonarcloud

services/Dockerfile

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ WORKDIR /opt/app-root/
99

1010
COPY --chown=node:node package*.json ./
1111

12+
RUN npm install -g npm@11
1213
RUN npm ci --ignore-scripts
1314

1415
COPY --chown=node:node . .
@@ -25,13 +26,11 @@ ARG NEST_APP=alcs
2526
WORKDIR /opt/app-root/
2627

2728
COPY --chown=node:node package*.json ./
28-
2929
COPY --chown=node:node --from=development /opt/app-root/node_modules ./node_modules
30-
3130
COPY --chown=node:node . .
3231

32+
RUN npm install -g npm@11
3333
RUN npm run build ${NEST_APP}
34-
3534
RUN npm ci --ignore-scripts --only=production && npm cache clean --force
3635

3736
USER node
@@ -60,6 +59,8 @@ COPY ./config/ /opt/app-root/config/
6059
COPY ./local-certificates /opt/app-root/local-certificates
6160
COPY ./templates/ /opt/app-root/templates/
6261

62+
RUN npm install -g npm@11
63+
6364
# Create Empty Config File if not Exists
6465
RUN mkdir -p /vault/secrets
6566
RUN touch /vault/secrets/config

0 commit comments

Comments
 (0)