Merge pull request #2742 from bcgov/e2e-test-troubleshoot

chore: updated e2e test wait time

Author: trslater

.github/workflows/e2e-test.yml

@@ -24,6 +24,7 @@ on:
   pull_request:
     branches:
       - main
+      - develop
 jobs:
   test:
     name: Playwright Tests

e2e/pages/alcs/alcs-login-page.ts

@@ -22,7 +22,16 @@ export class ALCSLoginPage {
   }
 
   async login(username: string, password: string) {
-    await this.idirLink.click();
+    // Click IDIR link and wait for navigation to external auth service
+    // Use domcontentloaded since external auth services can be slow
+    await Promise.all([
+      this.page.waitForURL('**/auth/**', { timeout: 30000, waitUntil: 'domcontentloaded' }),
+      this.idirLink.click(),
+    ]);
+
+    // Wait for login form to be ready
+    await this.userIdTextbox.waitFor({ state: 'visible', timeout: 30000 });
+
     await this.userIdTextbox.fill(username);
     await this.passwordTextbox.fill(password);
     await this.continueButton.click();

e2e/pages/portal/parcels-page.ts

@@ -168,7 +168,7 @@ export class ParcelsPage {
     await this.ownerSaveButton.click();
 
     // Wait for dialog to disappear
-    await expect(this.ownerAddDialog).toBeHidden();
+    await this.ownerAddDialog.waitFor({ state: 'hidden', timeout: 5000 });
   }
 
   // Actions

e2e/pages/portal/portal-login-page.ts

@@ -22,7 +22,16 @@ export class PortalLoginPage {
   }
 
   async logIn(username: string, password: string) {
-    await this.loginButton.click();
+    // Click login and wait for navigation to external auth service
+    // Use domcontentloaded since external auth services can be slow
+    await Promise.all([
+      this.page.waitForURL('**/auth/**', { timeout: 30000, waitUntil: 'domcontentloaded' }),
+      this.loginButton.click(),
+    ]);
+
+    // Wait for login form to be ready
+    await this.userIdTextbox.waitFor({ state: 'visible', timeout: 30000 });
+
     await this.userIdTextbox.fill(username);
     await this.passwordTextbox.fill(password);
     await this.continueButton.click();

e2e/playwright.config.ts

@@ -30,6 +30,10 @@ export default defineConfig({
 
     /* Collect trace when retrying the failed test. See https://playwright.dev/docs/trace-viewer */
     trace: 'on-first-retry',
+
+    /* Increase timeouts for external auth services which can be slow */
+    navigationTimeout: 30000,
+    actionTimeout: 30000,
   },
 
   /* Configure projects for major browsers */