Smarter test skipping

Author: ateucher

tests/testthat/helper.R

@@ -5,15 +5,24 @@ skip_on_actions <- function() {
   skip("On GitHub Actions")
 }
 
+skip_if_catalogue_function_tests_skipped <- function() {
+  if (nzchar(Sys.getenv("SKIP_CATALOGUE_FUNCTION_TESTS"))) {
+    skip("Skipping catalogue function tests")
+  }
+}
+
 make_local_cded_cache <- function(dir = tempdir(), env = parent.frame()) {
   cache_dir <- file.path(dir, "cded")
   make_mapsheet_dirs(cache_dir)
 
   # Use withr::defer to cleanup tempdir after exiting tests
   # https://www.tidyverse.org/blog/2020/04/self-cleaning-test-fixtures/
-  withr::defer({
-    unlink(cache_dir, recursive = TRUE, force = TRUE)
-  }, envir = env)
+  withr::defer(
+    {
+      unlink(cache_dir, recursive = TRUE, force = TRUE)
+    },
+    envir = env
+  )
 
   cache_dir
 }

tests/testthat/test-cache-utils.R

@@ -3,6 +3,7 @@ context("test-cache-utils")
 test_that("show_cached_files works", {
   skip_on_cran()
   skip_if_offline()
+  skip_if_catalogue_function_tests_skipped()
 
   datadir <- file.path(tempdir(), "bcmaps")
   withr::local_options(list("bcmaps.data_dir" = datadir))
@@ -18,9 +19,11 @@ test_that("show_cached_files works", {
   expect_equal(cache_info$is_dir, c(FALSE, TRUE))
 })
 
-test_that("the cache is deleted",{
+test_that("the cache is deleted", {
   skip_on_cran()
   skip_if_offline()
+  skip_if_catalogue_function_tests_skipped()
+
   expect_is(airzones(ask = FALSE, force = TRUE), "sf")
   expect_true(delete_cache("airzones"))
   expect_is(airzones(ask = FALSE, force = TRUE), "sf")

tests/testthat/test-cded.R

@@ -5,7 +5,7 @@ mapsheets_50_sf <- mapsheets_50K()
 test_that("list_mapsheet_files works", {
   skip_on_cran()
   skip_if_offline()
-  skip_if(nzchar(Sys.getenv("SKIP_CATALOGUE_FUNCTION_TESTS")))
+  skip_if_catalogue_function_tests_skipped()
 
   res <- list_mapsheet_files("https://pub.data.gov.bc.ca/datasets/175624/82g/")
   expect_type(res, "character")
@@ -31,6 +31,7 @@ test_that("making cded cache directory works", {
 test_that("get_mapsheet_tiles works", {
   skip_on_cran()
   skip_if_offline()
+  skip_if_catalogue_function_tests_skipped()
 
   cache_dir <- make_local_cded_cache()
 
@@ -81,6 +82,7 @@ test_that("get_mapsheet_tiles works", {
 test_that("cded works with tiles_50K", {
   skip_on_cran()
   skip_if_offline()
+  skip_if_catalogue_function_tests_skipped()
 
   vrt <- cded(tiles_50K = c("102o14", "095d01"))
 
@@ -97,6 +99,7 @@ test_that("cded works with tiles_50K", {
 test_that("cded works with aoi", {
   skip_on_cran()
   skip_if_offline()
+  skip_if_catalogue_function_tests_skipped()
 
   aoi <- st_buffer(
     mapsheets_sf[mapsheets_sf$MAP_TILE_DISPLAY_NAME == "102o", ],
@@ -132,6 +135,7 @@ test_that("cded works with aoi", {
 test_that("cded works with aoi with a different projection as mapsheets_250K", {
   skip_on_cran()
   skip_if_offline()
+  skip_if_catalogue_function_tests_skipped()
 
   aoi <- st_transform(
     st_buffer(
@@ -157,6 +161,7 @@ test_that("cded works with aoi with a different projection as mapsheets_250K", {
 if (require("stars")) {
   skip_on_cran()
   skip_if_offline()
+  skip_if_catalogue_function_tests_skipped()
 
   pol1 <- mapsheets_50K()[1, ]
   s <- st_as_stars(pol1)
@@ -172,6 +177,7 @@ if (require("stars")) {
 if (require("terra")) {
   skip_on_cran()
   skip_if_offline()
+  skip_if_catalogue_function_tests_skipped()
 
   pol1 <- mapsheets_50K()[1, ]
   r <- rast(pol1)

tests/testthat/test-data_functions.R

@@ -17,7 +17,7 @@ fn_names <- setdiff(fn_names, donttest)
 test_that("All sf layer function work without error and returns an sf object.", {
   skip_on_cran()
   skip_if_offline()
-  skip_if(nzchar(Sys.getenv("SKIP_CATALOGUE_FUNCTION_TESTS")))
+  skip_if_catalogue_function_tests_skipped()
 
   for (i in seq_along(fn_names)) {
     # cat("\n", fn_names[i]) #for debugging

tests/testthat/test-utils.R

@@ -22,13 +22,19 @@ sf_bbox_to_vec <- function(x) {
 
 test_that("bc_bbox works with all classes", {
   skip_on_cran()
+  skip_if_offline()
+  skip_if_catalogue_function_tests_skipped()
+
   sf_out <- sf_bbox_to_vec(bc_bbox())
   expect_equivalent(bc_bbox(), sf::st_bbox(bc_bound()))
   expect_equal(Extent_to_vec(bc_bbox("raster")), sf_out)
 })
 
 test_that("bc_bbox works with all classes and numeric crs", {
   skip_on_cran()
+  skip_if_offline()
+  skip_if_catalogue_function_tests_skipped()
+
   sf_out <- sf_bbox_to_vec(bc_bbox(crs = 4326))
   expect_equal(Extent_to_vec(bc_bbox("raster", crs = 4326)), sf_out)
 })
@@ -51,6 +57,12 @@ test_that("clean_geos_version works", {
   expect_equal(clean_geos_version("3.9.0dev1"), "3.9.0-9999-1")
   expect_equal(clean_geos_version("3.9.0"), "3.9.0")
 
-  expect_equal(unclass(numeric_version(clean_geos_version("3.9.0dev1"))), list(c(3, 9, 0, 9999, 1)))
-  expect_equal(unclass(numeric_version(clean_geos_version("3.9.0-dev-1"))), list(c(3, 9, 0, 9999, 1)))
+  expect_equal(
+    unclass(numeric_version(clean_geos_version("3.9.0dev1"))),
+    list(c(3, 9, 0, 9999, 1))
+  )
+  expect_equal(
+    unclass(numeric_version(clean_geos_version("3.9.0-dev-1"))),
+    list(c(3, 9, 0, 9999, 1))
+  )
 })