Unit test and fix errorToProblem logic

Signed-off-by: Jeremy Ho <jujaga@gmail.com>

Author: jujaga

app/src/components/errorToProblem.js

@@ -1,20 +1,28 @@
 const log = require('npmlog');
 const Problem = require('api-problem');
 
-module.exports = function (service, e) {
+module.exports = function(service, e) {
   if (e.response) {
-    log.error(`Error from ${service}: status = ${e.response.status}, data : ${e.response.data}`);
+    // Handle raw data
+    let data;
+    if (typeof e.response.data === 'string' || e.response.data instanceof String) {
+      data = JSON.parse(e.response.data);
+    } else {
+      data = e.response.data;
+    }
+
+    log.error(`Error from ${service}: status = ${e.response.status}, data : ${JSON.stringify(data)}`);
     // Validation Error
     if (e.response.status === 422) {
       throw new Problem(e.response.status, {
-        detail: e.response.data.detail,
-        errors: JSON.parse(e.response.data).errors
+        detail: data.detail,
+        errors: data.errors
       });
     }
     // Something else happened but there's a response
-    throw new Problem(e.response.status, {detail: e.response.data.toString()});
+    throw new Problem(e.response.status, { detail: e.response.data.toString() });
   } else {
     log.error(`Unknown error calling ${service}: ${e.message}`);
-    throw new Problem(502, `Unknown ${service} Error`, {detail: e.message});
+    throw new Problem(502, `Unknown ${service} Error`, { detail: e.message });
   }
 };

app/tests/unit/components/errorToProblem.spec.js

@@ -0,0 +1,25 @@
+const errorToProblem = require('../../../src/components/errorToProblem');
+const helper = require('../../common/helper');
+
+const SERVICE = 'TESTSERVICE';
+
+helper.logHelper();
+
+describe('errorToProblem', () => {
+  it('should throw a 422', () => {
+    const e = {
+      response: {
+        data: { detail: 'detail' },
+        status: 422
+      }
+    };
+    expect(() => errorToProblem(SERVICE, e)).toThrow('422');
+  });
+
+  it('should throw a 502', () => {
+    const e = {
+      message: 'msg'
+    };
+    expect(() => errorToProblem(SERVICE, e)).toThrow('502');
+  });
+});