feature/dep272: More Sonar Cube fixes

Author: jareth-whitney

api/tests/utilities/factory_scenarios.py

@@ -34,6 +34,7 @@
 fake = Faker()
 
 CONFIG = get_named_config('testing')
+DATE_FORMAT = '%Y/%m/%d, %H:%M:%S'
 
 
 class TestUserInfo(dict, Enum):
@@ -185,8 +186,8 @@ class TestEngagementInfo(dict, Enum):
 
     engagement1 = {
         'name': fake.name(),
-        'start_date': (datetime.today() - timedelta(days=1)).strftime('%Y/%m/%d, %H:%M:%S'),
-        'end_date': (datetime.today() + timedelta(days=1)).strftime('%Y/%m/%d, %H:%M:%S'),
+        'start_date': (datetime.today() - timedelta(days=1)).strftime(DATE_FORMAT),
+        'end_date': (datetime.today() + timedelta(days=1)).strftime(DATE_FORMAT),
         'banner_url': '',
         'created_by': '123',
         'updated_by': '123',
@@ -206,8 +207,8 @@ class TestEngagementInfo(dict, Enum):
 
     engagement_draft = {
         'name': fake.name(),
-        'start_date': (datetime.today() - timedelta(days=1)).strftime('%Y/%m/%d, %H:%M:%S'),
-        'end_date': (datetime.today() + timedelta(days=1)).strftime('%Y/%m/%d, %H:%M:%S'),
+        'start_date': (datetime.today() - timedelta(days=1)).strftime(DATE_FORMAT),
+        'end_date': (datetime.today() + timedelta(days=1)).strftime(DATE_FORMAT),
         'banner_url': '',
         'created_by': '123',
         'updated_by': '123',
@@ -226,8 +227,8 @@ class TestEngagementInfo(dict, Enum):
 
     engagement2 = {
         'name': fake.name(),
-        'start_date': (datetime.today() - timedelta(days=1)).strftime('%Y/%m/%d, %H:%M:%S'),
-        'end_date': (datetime.today() + timedelta(days=1)).strftime('%Y/%m/%d, %H:%M:%S'),
+        'start_date': (datetime.today() - timedelta(days=1)).strftime(DATE_FORMAT),
+        'end_date': (datetime.today() + timedelta(days=1)).strftime(DATE_FORMAT),
         'banner_url': '',
         'created_by': '123',
         'updated_by': '123',
@@ -258,8 +259,8 @@ class TestEngagementInfo(dict, Enum):
 
     engagement3 = {
         'name': fake.name(),
-        'start_date': (datetime.today() - timedelta(days=1)).strftime('%Y/%m/%d, %H:%M:%S'),
-        'end_date': (datetime.today() + timedelta(days=1)).strftime('%Y/%m/%d, %H:%M:%S'),
+        'start_date': (datetime.today() - timedelta(days=1)).strftime(DATE_FORMAT),
+        'end_date': (datetime.today() + timedelta(days=1)).strftime(DATE_FORMAT),
         'banner_url': '',
         'tenant_id': 1,
         'created_by': '123',

web/src/components/common/Navigation/Breadcrumb.tsx

@@ -94,7 +94,7 @@ export const AutoBreadcrumbs: React.FC<{ smallScreenOnly?: boolean }> = ({ small
     useEffect(() => {
         let cancelled = false;
 
-        const getNewCrumbs = (
+        const setNewCrumbs = (
             resolvedCrumb: BreadcrumbProps,
             previousCrumbs: Record<string, BreadcrumbProps>,
             pathname: string,
@@ -112,17 +112,13 @@ export const AutoBreadcrumbs: React.FC<{ smallScreenOnly?: boolean }> = ({ small
             };
         };
 
-        crumbs.forEach((unresolvedCrumb, index) => {
+        crumbs.forEach(async (unresolvedCrumb, index) => {
             const pathname = matches[index]?.pathname;
-
             if (!pathname) return;
 
-            Promise.resolve(unresolvedCrumb)
-                .then((resolvedCrumb) => {
-                    if (cancelled) return;
-                    setResolvedCrumbs((previousCrumbs) => getNewCrumbs(resolvedCrumb, previousCrumbs, pathname));
-                })
-                .catch(() => {});
+            const resolvedCrumb = await unresolvedCrumb;
+            if (cancelled) return;
+            setResolvedCrumbs((previousCrumbs) => setNewCrumbs(resolvedCrumb, previousCrumbs, pathname));
         });
 
         return () => {

web/src/components/engagement/admin/create/authoring/AuthoringBottomNav.tsx

@@ -421,7 +421,7 @@ const LanguageSelector = ({
 
     useEffect(() => {
         languages.then((lngs) => {
-            if (!lngs.find((l) => l.code === 'en')) {
+            if (!lngs.some((l) => l.code === 'en')) {
                 lngs.unshift({ id: 42, code: 'en', name: 'English', right_to_left: false });
             }
             setLanguageList(lngs);