Merge pull request #2658 from bcgov/DESENG-847-use-deployments-not-deploymentconfigs

Finish upgrading DeploymentConfigs -> Deployments cross-app

Author: NatSquared

.github/PULL_REQUEST_TEMPLATE.md

@@ -4,10 +4,10 @@ Issue #: https://citz-gdx.atlassian.net/browse/DESENG-XXX
 
 **User Guide update ticket (if applicable):**
 
-- [ ] Yes, a user guide update ticket has been created. _(Link to ticket)_
-- [ ] No, a user guide update ticket is not required.
+- - [ ] Yes, a user guide update ticket has been created. _(Link to ticket)_
+- - [ ] No, a user guide update ticket is not required.
 
 **Common component changes:**
 
-- [ ] Yes, I have updated CONTRIBUTING.md and the docblocks to document any changes to the common components.
-- [ ] No, there are no changes to the common components.
+- - [ ] Yes, I have updated CONTRIBUTING.md and the docblocks to document any changes to the common components.
+- - [ ] No, there are no changes to the common components.

.github/workflows/analytics-api-cd.yml

@@ -74,4 +74,4 @@ jobs:
       - name: Rollout
         shell: bash
         run: |
-          oc rollout status dc/${{ env.APP_NAME }} -n ${{ env.OPENSHIFT_REPOSITORY }}-${{ env.TAG_NAME }} -w
+          oc rollout status deployment/${{ env.APP_NAME }} -n ${{ env.OPENSHIFT_REPOSITORY }}-${{ env.TAG_NAME }} -w

.github/workflows/met-api-cd.yml

@@ -74,4 +74,4 @@ jobs:
       - name: Rollout
         shell: bash
         run: |
-          oc rollout status dc/${{ env.APP_NAME }} -n ${{ env.OPENSHIFT_REPOSITORY }}-${{ env.TAG_NAME }} -w
+          oc rollout status deployment/${{ env.APP_NAME }} -n ${{ env.OPENSHIFT_REPOSITORY }}-${{ env.TAG_NAME }} -w

.github/workflows/met-cron-cd.yml

@@ -75,4 +75,4 @@ jobs:
       - name: Rollout
         shell: bash
         run: |
-          oc rollout status dc/${{ env.APP_NAME }} -n ${{ env.OPENSHIFT_REPOSITORY }}-${{ env.TAG_NAME }} -w
+          oc rollout status deployment/${{ env.APP_NAME }} -n ${{ env.OPENSHIFT_REPOSITORY }}-${{ env.TAG_NAME }} -w

.github/workflows/met-web-cd.yml

@@ -86,4 +86,4 @@ jobs:
       - name: Rollout
         shell: bash
         run: |
-          oc rollout status dc/${{ env.APP_NAME }} -n ${{ env.OPENSHIFT_REPOSITORY }}-${{ env.TAG_NAME }} -w
+          oc rollout status deployment/${{ env.APP_NAME }} -n ${{ env.OPENSHIFT_REPOSITORY }}-${{ env.TAG_NAME }} -w

.github/workflows/notify-api-cd.yml

@@ -74,4 +74,4 @@ jobs:
       - name: Rollout
         shell: bash
         run: |
-          oc rollout status dc/${{ env.APP_NAME }} -n ${{ env.OPENSHIFT_REPOSITORY }}-${{ env.TAG_NAME }} -w
+          oc rollout status deployment/${{ env.APP_NAME }} -n ${{ env.OPENSHIFT_REPOSITORY }}-${{ env.TAG_NAME }} -w

CHANGELOG.MD

@@ -1,3 +1,9 @@
+## August 22, 2025
+
+- **Bugfix** Finish upgrading DeploymentConfigs -> Deployments cross-app [🎟️ DESENG-847](https://citz-gdx.atlassian.net/browse/DESENG-847)
+  - Completed the replacement of all deprecated DeploymentConfigs with Deployments across the application.
+  - Updated Helm charts and deployment scripts to reflect the changes.
+
 ## August 19, 2025
 
 - **Feature** Restricted options for values in manual CD runs

openshift/analytics-api/templates/hpa.yaml

@@ -4,7 +4,7 @@ metadata:
   name: {{ .Values.app.name }}
 spec:
   scaleTargetRef:
-    kind: DeploymentConfig
+    kind: Deployment
     name: {{ .Values.app.name }}
     apiVersion: apps.openshift.io/v1
   minReplicas: {{ .Values.hpa.minReplicas }}

openshift/api/templates/hpa.yaml

@@ -7,7 +7,7 @@ metadata:
     app-group: met-app
 spec:
   scaleTargetRef:
-    kind: DeploymentConfig
+    kind: Deployment
     name: {{ .Values.app.name }}
     apiVersion: apps.openshift.io/v1
   minReplicas: {{ .Values.deployment.minReplicas }}

openshift/deploy.sh

@@ -8,5 +8,5 @@ oc tag met-web:latest met-web:$1
 oc tag met-analytics:latest met-analytics:$1
 oc tag dagster-etl:latest dagster-etl:$1
 
-oc rollout status dc/met-api -n $2-$1 -w
-oc rollout status dc/met-web -n $2-$1 -w
+oc rollout status deployment/met-api -n $2-$1 -w
+oc rollout status deployment/met-web -n $2-$1 -w