fix: update Helm values file naming convention to use underscores

Author: NatSquared

.github/workflows/infrastructure-ci-cd.yml

@@ -163,9 +163,9 @@ jobs:
         working-directory: "${{ matrix.chart.dir }}"
         run: |
           helm dependency update
-          if [[ -f values-${{ matrix.environment }}.yaml ]]; then
-            helm lint . --values values-${{ matrix.environment }}.yaml
-            helm template . --values values-${{ matrix.environment }}.yaml --dry-run > /dev/null
+          if [[ -f values_${{ matrix.environment }}.yaml ]]; then
+            helm lint . --values values_${{ matrix.environment }}.yaml
+            helm template . --values values_${{ matrix.environment }}.yaml --dry-run > /dev/null
           else
             helm lint .
             helm template . --dry-run > /dev/null
@@ -174,8 +174,8 @@ jobs:
       - name: Validate with kubeval
         working-directory: "${{ matrix.chart.dir }}"
         run: |
-          if [[ -f values-${{ matrix.environment }}.yaml ]]; then
-            helm template . --values values-${{ matrix.environment }}.yaml | kubeval --strict --ignore-missing-schemas
+          if [[ -f values_${{ matrix.environment }}.yaml ]]; then
+            helm template . --values values_${{ matrix.environment }}.yaml | kubeval --strict --ignore-missing-schemas
           else
             helm template . | kubeval --strict --ignore-missing-schemas
           fi
@@ -218,7 +218,7 @@ jobs:
             ${{ matrix.chart.name }} \
             . \
             --namespace "$NAMESPACE" \
-            --values values-${{ matrix.environment }}.yaml \
+            --values values_${{ matrix.environment }}.yaml \
             --atomic \
             --timeout 10m \
       - name: Verify deployment