Skip to content

Commit 99a73d3

Browse files
committed
DESENG-820 Hotfix: Update docker build process
1 parent 51e52ee commit 99a73d3

3 files changed

Lines changed: 16 additions & 16 deletions

File tree

.github/workflows/met-api-cd.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,9 @@ jobs:
6060
6161
- name: Build image
6262
run: |
63-
docker build . --file Dockerfile \
63+
TZ='America/Vancouver' docker build . --file Dockerfile \
6464
--build-arg MET_BUILD_COMMIT_HASH=${{ github.sha }} \
65-
--build-arg MET_BUILD_DATE="$(date -u +'%b %d, %Y @ %H:%M')" \
65+
--build-arg MET_BUILD_DATE="$(date +'%b %d, %Y @ %H:%M')" \
6666
--build-arg MET_BUILD_BRANCH=${{ github.ref_name }} \
6767
--build-arg MET_GITHUB_REPO="https://github.com/${{ github.repository }}" \
6868
--tag image

.github/workflows/met-web-cd.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,11 +70,11 @@ jobs:
7070
env:
7171
DOCKER_BUILDKIT: 1
7272
run: |
73-
docker build . --file Dockerfile \
73+
TZ='America/Vancouver' docker build . --file Dockerfile \
7474
--secret id=artifactory_username,src=/tmp/artifactory_username \
7575
--secret id=artifactory_password,src=/tmp/artifactory_password \
7676
--build-arg REACT_APP_BUILD_COMMIT_HASH=${{ github.sha }} \
77-
--build-arg REACT_APP_BUILD_DATE="$(date -u +'%b %d, %Y @ %H:%M')" \
77+
--build-arg REACT_APP_BUILD_DATE="$(date +'%b %d, %Y @ %H:%M')" \
7878
--build-arg REACT_APP_BUILD_BRANCH=${{ github.ref_name }} \
7979
--build-arg REACT_APP_GITHUB_REPO="https://github.com/${{ github.repository }}" \
8080
--tag image

met-web/Dockerfile

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,18 @@
22
# pull official base image
33
FROM node:20-alpine AS build-stage
44

5+
# Accept build arguments for version information to pass to runtime
6+
ARG REACT_APP_BUILD_COMMIT_HASH=dev
7+
ARG REACT_APP_BUILD_DATE=unknown
8+
ARG REACT_APP_BUILD_BRANCH=unknown
9+
ARG REACT_APP_GITHUB_REPO=https://github.com/bcgov/met-public
10+
11+
# Set as environment variables for runtime access
12+
ENV REACT_APP_BUILD_COMMIT_HASH=${REACT_APP_BUILD_COMMIT_HASH}
13+
ENV REACT_APP_BUILD_DATE=${REACT_APP_BUILD_DATE}
14+
ENV REACT_APP_BUILD_BRANCH=${REACT_APP_BUILD_BRANCH}
15+
ENV REACT_APP_GITHUB_REPO=${REACT_APP_GITHUB_REPO}
16+
517
# set working directory
618
WORKDIR /app
719

@@ -32,18 +44,6 @@ RUN npm run build
3244
# Stage 1, based on Nginx, to have only the compiled app, ready for production with Nginx
3345
FROM nginx:1.17 AS production-stage
3446

35-
# Accept build arguments for version information to pass to runtime
36-
ARG REACT_APP_BUILD_COMMIT_HASH=dev
37-
ARG REACT_APP_BUILD_DATE=unknown
38-
ARG REACT_APP_BUILD_BRANCH=unknown
39-
ARG REACT_APP_GITHUB_REPO=https://github.com/bcgov/met-public
40-
41-
# Set as environment variables for runtime access
42-
ENV REACT_APP_BUILD_COMMIT_HASH=${REACT_APP_BUILD_COMMIT_HASH}
43-
ENV REACT_APP_BUILD_DATE=${REACT_APP_BUILD_DATE}
44-
ENV REACT_APP_BUILD_BRANCH=${REACT_APP_BUILD_BRANCH}
45-
ENV REACT_APP_GITHUB_REPO=${REACT_APP_GITHUB_REPO}
46-
4747
RUN mkdir /app
4848

4949
# RUN touch /var/run/nginx.pid && \

0 commit comments

Comments
 (0)