Fix existing bug: onRemoveFile incorrect index check - files are now properly removed, not just shown to be removed in the UI for FilePond

alazar-aot · alazar-aot · commit 0af85fb684bc · 2026-05-19T13:55:27.000-07:00
diff --git a/services/common/src/components/project/envApplication/EnvDocumentsTab.tsx b/services/common/src/components/project/envApplication/EnvDocumentsTab.tsx
@@ -110,7 +110,7 @@ const EnvDocumentsTab = () => {
     const onRemoveFile = (_error, file) => {
         const document_manager_guid = file?.serverId;
         const docIndex = formValues.documents.findIndex((d) => d.document_manager_guid === document_manager_guid);
-        if (docIndex) {
+        if (docIndex !== -1) {
             dispatch(arrayRemove(formName, "documents", docIndex));
         }
     };

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ const EnvDocumentsTab = () => {`
`110`	`110`	`const onRemoveFile = (_error, file) => {`
`111`	`111`	`const document_manager_guid = file?.serverId;`
`112`	`112`	`const docIndex = formValues.documents.findIndex((d) => d.document_manager_guid === document_manager_guid);`
`113`		`- if (docIndex) {`
	`113`	`+ if (docIndex !== -1) {`
`114`	`114`	`dispatch(arrayRemove(formName, "documents", docIndex));`
`115`	`115`	`}`
`116`	`116`	`};`