sonar fix (#398)

Author: yzlucas

client/wfprev-war/src/main/angular/src/app/components/create-new-project-dialog/create-new-project-dialog.component.ts

@@ -43,8 +43,8 @@ export class CreateNewProjectDialogComponent implements OnInit {
     private readonly dialog: MatDialog,
     private readonly dialogRef: MatDialogRef<CreateNewProjectDialogComponent>,
     private readonly snackbarService: MatSnackBar,
-    private projectService: ProjectService,
-    private codeTableService: CodeTableServices
+    private readonly projectService: ProjectService,
+    private readonly codeTableService: CodeTableServices
 
   ) {
     this.projectForm = this.fb.group({
@@ -101,7 +101,7 @@ export class CreateNewProjectDialogComponent implements OnInit {
   }
   getErrorMessage(controlName: string): string | null {
     const control = this.projectForm.get(controlName);
-    if (!control || !control.errors) return null;
+    if (!control?.errors) return null;
 
     if (control.hasError('required')) {
       return this.messages.requiredField;

client/wfprev-war/src/main/angular/src/app/components/list-panel/projects-list/projects-list.component.ts

@@ -22,10 +22,10 @@ export class ProjectsListComponent implements OnInit {
   programAreaCode: any[] = [];
   forestRegionCode: any[] = [];
   constructor(
-    private router: Router,
-    private projectService: ProjectService,
-    private codeTableService: CodeTableServices,
-    private dialog: MatDialog
+    private readonly router: Router,
+    private readonly projectService: ProjectService,
+    private readonly codeTableService: CodeTableServices,
+    private readonly dialog: MatDialog
 
   ) {
   }

client/wfprev-war/src/main/angular/src/app/services/code-table-services.ts

@@ -11,9 +11,9 @@ export class CodeTableServices {
   private codeTableCache: { [key: string]: any } = {}; // Cache for code tables
 
   constructor(
-    private appConfigService: AppConfigService,
-    private httpClient: HttpClient,
-    private tokenService: TokenService,
+    private readonly appConfigService: AppConfigService,
+    private readonly httpClient: HttpClient,
+    private readonly tokenService: TokenService,
   ) {}
 
   fetchCodeTable(codeTableName: string): Observable<any> {

client/wfprev-war/src/main/angular/src/app/services/project-services.ts

@@ -10,9 +10,9 @@ import { TokenService } from "src/app/services/token.service";
 
 export class ProjectService {
     constructor(
-        private appConfigService: AppConfigService,
-        private httpClient: HttpClient,
-        private tokenService: TokenService,
+        private readonly appConfigService: AppConfigService,
+        private readonly httpClient: HttpClient,
+        private readonly tokenService: TokenService,
     ){
     }