fix dropdown menu position, also add max length restriction on resultsID and results projec… (#782)

Author: yzlucas

client/wfprev-war/src/main/angular/src/app/components/edit-project/project-details/project-details.component.ts

@@ -121,7 +121,7 @@ export class ProjectDetailsComponent implements OnInit, AfterViewInit, OnDestroy
       fireCentreId: ['', [Validators.required]],
       latitude: [''],
       longitude: [''],
-      resultsProjectCode: ['', [Validators.maxLength(25)]]
+      resultsProjectCode: ['', [Validators.maxLength(8)]]
     });
     this.latLongForm = this.fb.group({
       latitude: ['', Validators.required],

client/wfprev-war/src/main/angular/src/app/components/edit-project/project-fiscals/project-fiscals.component.html

@@ -34,7 +34,7 @@
                     </button>
                   </div>
                 </mat-expansion-panel-header>
-                <mat-menu #menu="matMenu">
+                <mat-menu #menu="matMenu" xPosition="before">
                   <button mat-menu-item (click)="deleteFiscalYear(fiscalForms[i],i)" [disabled]="isUndeletable(fiscalForms[i])">
                     Delete Fiscal Year
                   </button>
@@ -141,6 +141,7 @@
                       [placeholder]="'Begin Typing'"
                       [control]="getFiscalControl(selectedTabIndex, 'resultsOpeningId')"
                       [tooltip]="getFiscalControl(selectedTabIndex, 'resultsOpeningId')?.value"
+                      [errorMessages]="{ maxlength: messages.maxLengthExceeded }"
                     />
                   </div>
 

client/wfprev-war/src/main/angular/src/app/components/edit-project/project-fiscals/project-fiscals.component.ts

@@ -164,7 +164,7 @@ export class ProjectFiscalsComponent implements OnInit, CanComponentDeactivate
       planFiscalStatusCode: [fiscal?.planFiscalStatusCode ?? 'DRAFT', [Validators.required]],
       fiscalPlannedProjectSizeHa: [fiscal?.fiscalPlannedProjectSizeHa ?? '', [Validators.min(0)]],
       fiscalCompletedSizeHa: [fiscal?.fiscalCompletedSizeHa ?? '', [Validators.min(0)]],
-      resultsOpeningId: [fiscal?.resultsOpeningId ?? ''],
+      resultsOpeningId: [fiscal?.resultsOpeningId ?? '', [Validators.maxLength(11)]],
       firstNationsEngagementInd: [fiscal?.firstNationsEngagementInd ?? false],
       firstNationsDelivPartInd: [fiscal?.firstNationsDelivPartInd ?? false],
       firstNationsPartner: [fiscal?.firstNationsPartner ?? ''],

client/wfprev-war/src/main/angular/src/styles.scss

@@ -9,31 +9,6 @@ body {
     margin: 0;
 }
 
-.cdk-overlay-container {
-    z-index: 1000000 !important;
-    .cdk-overlay-connected-position-bounding-box{
-        position: absolute;
-        z-index: 1000000 !important;
-        display: flex;
-        flex-direction: column;
-        min-width: 1px;
-        min-height: 1px;
-        top: 46px;
-        left: 1374.73px;
-        height: 1267px;
-        width: 146.266px;
-        align-items: flex-start;
-        justify-content: flex-start;
-        .cdk-overlay-pane{
-            background-color: var(--wf-colour-white);
-            border-radius: 4px;
-        }
-        .mat-mdc-menu-item-text{
-            text-align: center;
-        }
-    }
-}
-
 .mat-mdc-snack-bar-container{
   .mdc-snackbar__label{
     color: var(--wf-colour-white);
@@ -167,4 +142,4 @@ mat-icon,
   height: 16px;
   margin-right: 8px;
   border-radius: 2px;
-}
+}