Skip to content

Commit 42ddf93

Browse files
committed
Fix request parameter name mismatch
1 parent 7b0a7b1 commit 42ddf93

File tree

4 files changed

+57
-57
lines changed

4 files changed

+57
-57
lines changed

client/wfprev-war/src/main/angular/src/app/components/list-panel/projects-list/projects-list.component.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -725,14 +725,14 @@ export class ProjectsListComponent implements OnInit {
725725

726726
if (filters && Object.keys(filters).length > 0) {
727727
body.projectFilter = {
728-
programAreaGuid: filters.programAreaGuid,
729-
fiscalYear: filters.fiscalYear,
730-
forestRegionOrgUnitId: filters.forestRegionOrgUnitId,
731-
forestDistrictOrgUnitId: filters.forestDistrictOrgUnitId,
732-
fireCentreOrgUnitId: filters.fireCentreOrgUnitId,
733-
activityCategoryCode: filters.activityCategoryCode,
734-
planFiscalStatusCode: filters.planFiscalStatusCode,
735-
projectTypeCode: filters.projectTypeCode,
728+
programAreaGuids: filters.programAreaGuid,
729+
fiscalYears: filters.fiscalYear,
730+
forestRegionOrgUnitIds: filters.forestRegionOrgUnitId,
731+
forestDistrictOrgUnitIds: filters.forestDistrictOrgUnitId,
732+
fireCentreOrgUnitIds: filters.fireCentreOrgUnitId,
733+
activityCategoryCodes: filters.activityCategoryCode,
734+
planFiscalStatusCodes: filters.planFiscalStatusCode,
735+
projectTypeCodes: filters.projectTypeCode,
736736
searchText: filters.searchText
737737
};
738738
} else {

client/wfprev-war/src/main/angular/src/app/components/models.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -357,14 +357,14 @@ export interface ReportProject {
357357
}
358358

359359
export interface ProjectFilter {
360-
programAreaGuid?: string[];
361-
fiscalYear?: string[];
362-
forestRegionOrgUnitId?: string[];
363-
forestDistrictOrgUnitId?: string[];
364-
fireCentreOrgUnitId?: string[];
365-
activityCategoryCode?: string[];
366-
planFiscalStatusCode?: string[];
367-
projectTypeCode?: string[];
360+
programAreaGuids?: string[];
361+
fiscalYears?: string[];
362+
forestRegionOrgUnitIds?: string[];
363+
forestDistrictOrgUnitIds?: string[];
364+
fireCentreOrgUnitIds?: string[];
365+
activityCategoryCodes?: string[];
366+
planFiscalStatusCodes?: string[];
367+
projectTypeCodes?: string[];
368368
searchText?: string;
369369
sortBy?: string;
370370
sortDirection?: string;

client/wfprev-war/src/main/angular/src/app/components/search-filter/search-filter.component.ts

Lines changed: 33 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,14 @@ export class SearchFilterComponent implements OnInit {
4646
const saved = this.projectFilterStateService.filters();
4747
if (saved) {
4848
this.searchText = saved.searchText ?? "";
49-
this.selectedProjectType = saved.projectTypeCode ?? [];
50-
this.selectedBusinessArea = saved.programAreaGuid ?? [];
51-
this.selectedFiscalYears = saved.fiscalYear ?? [];
52-
this.selectedActivity = saved.activityCategoryCode ?? [];
53-
this.selectedForestRegion = saved.forestRegionOrgUnitId ?? [];
54-
this.selectedForestDistrict = saved.forestDistrictOrgUnitId ?? [];
55-
this.selectedFireCentre = saved.fireCentreOrgUnitId ?? [];
56-
this.selectedFiscalStatus = saved.planFiscalStatusCode ?? [];
49+
this.selectedProjectType = saved.projectTypeCodes ?? [];
50+
this.selectedBusinessArea = saved.programAreaGuids ?? [];
51+
this.selectedFiscalYears = saved.fiscalYears ?? [];
52+
this.selectedActivity = saved.activityCategoryCodes ?? [];
53+
this.selectedForestRegion = saved.forestRegionOrgUnitIds ?? [];
54+
this.selectedForestDistrict = saved.forestDistrictOrgUnitIds ?? [];
55+
this.selectedFireCentre = saved.fireCentreOrgUnitIds ?? [];
56+
this.selectedFiscalStatus = saved.planFiscalStatusCodes ?? [];
5757
}
5858

5959
});
@@ -84,14 +84,14 @@ export class SearchFilterComponent implements OnInit {
8484
const savedFilters = this.projectFilterStateService.filters();
8585
if (savedFilters) {
8686
this.searchText = savedFilters?.searchText ?? '';
87-
this.selectedProjectType = savedFilters?.projectTypeCode ?? [];
88-
this.selectedBusinessArea = savedFilters?.programAreaGuid ?? [];
89-
this.selectedFiscalYears = savedFilters?.fiscalYear ?? [];
90-
this.selectedActivity = savedFilters?.activityCategoryCode ?? [];
91-
this.selectedForestRegion = savedFilters?.forestRegionOrgUnitId ?? [];
92-
this.selectedForestDistrict = savedFilters?.forestDistrictOrgUnitId ?? [];
93-
this.selectedFireCentre = savedFilters?.fireCentreOrgUnitId ?? [];
94-
this.selectedFiscalStatus = savedFilters?.planFiscalStatusCode ?? [];
87+
this.selectedProjectType = savedFilters?.projectTypeCodes ?? [];
88+
this.selectedBusinessArea = savedFilters?.programAreaGuids ?? [];
89+
this.selectedFiscalYears = savedFilters?.fiscalYears ?? [];
90+
this.selectedActivity = savedFilters?.activityCategoryCodes ?? [];
91+
this.selectedForestRegion = savedFilters?.forestRegionOrgUnitIds ?? [];
92+
this.selectedForestDistrict = savedFilters?.forestDistrictOrgUnitIds ?? [];
93+
this.selectedFireCentre = savedFilters?.fireCentreOrgUnitIds ?? [];
94+
this.selectedFiscalStatus = savedFilters?.planFiscalStatusCodes ?? [];
9595
}
9696
this.generateFiscalYearOptions();
9797
this.setupCodeTableSubscription();
@@ -116,25 +116,25 @@ export class SearchFilterComponent implements OnInit {
116116

117117
this.projectFilterStateService.update({
118118
searchText: this.searchText,
119-
projectTypeCode: this.selectedProjectType,
120-
programAreaGuid: this.selectedBusinessArea,
121-
fiscalYear: this.selectedFiscalYears,
122-
activityCategoryCode: this.selectedActivity,
123-
forestRegionOrgUnitId: this.selectedForestRegion,
124-
forestDistrictOrgUnitId: this.selectedForestDistrict,
125-
fireCentreOrgUnitId: this.selectedFireCentre,
126-
planFiscalStatusCode: this.selectedFiscalStatus
119+
projectTypeCodes: this.selectedProjectType,
120+
programAreaGuids: this.selectedBusinessArea,
121+
fiscalYears: this.selectedFiscalYears,
122+
activityCategoryCodes: this.selectedActivity,
123+
forestRegionOrgUnitIds: this.selectedForestRegion,
124+
forestDistrictOrgUnitIds: this.selectedForestDistrict,
125+
fireCentreOrgUnitIds: this.selectedFireCentre,
126+
planFiscalStatusCodes: this.selectedFiscalStatus
127127
});
128128
const filterPrarameters: ProjectFilter = {
129129
searchText: this.searchText,
130-
projectTypeCode: sanitize(this.selectedProjectType),
131-
programAreaGuid: sanitize(this.selectedBusinessArea),
132-
fiscalYear: resolveFiscalYears(),
133-
activityCategoryCode: sanitize(this.selectedActivity),
134-
forestRegionOrgUnitId: sanitize(this.selectedForestRegion),
135-
forestDistrictOrgUnitId: sanitize(this.selectedForestDistrict),
136-
fireCentreOrgUnitId: sanitize(this.selectedFireCentre),
137-
planFiscalStatusCode: sanitize(this.selectedFiscalStatus)
130+
projectTypeCodes: sanitize(this.selectedProjectType),
131+
programAreaGuids: sanitize(this.selectedBusinessArea),
132+
fiscalYears: resolveFiscalYears(),
133+
activityCategoryCodes: sanitize(this.selectedActivity),
134+
forestRegionOrgUnitIds: sanitize(this.selectedForestRegion),
135+
forestDistrictOrgUnitIds: sanitize(this.selectedForestDistrict),
136+
fireCentreOrgUnitIds: sanitize(this.selectedFireCentre),
137+
planFiscalStatusCodes: sanitize(this.selectedFiscalStatus)
138138
}
139139

140140
this.sharedService.updateFilters(filterPrarameters);
@@ -378,7 +378,7 @@ export class SearchFilterComponent implements OnInit {
378378
}
379379

380380
assignDefaultFiscalYear(emit: boolean = true): void {
381-
if (!this.projectFilterStateService?.filters()?.fiscalYear) {
381+
if (!this.projectFilterStateService?.filters()?.fiscalYears) {
382382
const today = new Date();
383383
// April has an index of 3
384384
const fiscalYearStart = today.getMonth() >= 3 ? today.getFullYear() : today.getFullYear() - 1;

server/wfprev-api/src/main/java/ca/bc/gov/nrs/wfprev/controllers/FeaturesController.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -62,14 +62,14 @@ public FeaturesController(FeaturesService featuresService) {
6262
required = true, schema = @Schema(implementation = String.class), in = ParameterIn.HEADER)
6363
public ResponseEntity<Map<String, Object>> getAllFeatures(
6464
@RequestParam(required = false) UUID projectGuid,
65-
@RequestParam(required = false) List<UUID> programAreaGuid,
66-
@RequestParam(required = false) List<String> fiscalYear,
67-
@RequestParam(required = false) List<String> activityCategoryCode,
68-
@RequestParam(required = false) List<String> planFiscalStatusCode,
69-
@RequestParam(required = false) List<String> forestRegionOrgUnitId,
70-
@RequestParam(required = false) List<String> forestDistrictOrgUnitId,
71-
@RequestParam(required = false) List<String> fireCentreOrgUnitId,
72-
@RequestParam(required = false) List<String> projectTypeCode,
65+
@RequestParam(name = "programAreaGuids", required = false) List<UUID> programAreaGuid,
66+
@RequestParam(name = "fiscalYears", required = false) List<String> fiscalYear,
67+
@RequestParam(name = "activityCategoryCodes", required = false) List<String> activityCategoryCode,
68+
@RequestParam(name = "planFiscalStatusCodes", required = false) List<String> planFiscalStatusCode,
69+
@RequestParam(name = "forestRegionOrgUnitIds", required = false) List<String> forestRegionOrgUnitId,
70+
@RequestParam(name = "forestDistrictOrgUnitIds", required = false) List<String> forestDistrictOrgUnitId,
71+
@RequestParam(name = "fireCentreOrgUnitIds", required = false) List<String> fireCentreOrgUnitId,
72+
@RequestParam(name = "projectTypeCodes", required = false) List<String> projectTypeCode,
7373
@RequestParam(required = false) String searchText,
7474
@RequestParam(defaultValue = "1") int pageNumber,
7575
@RequestParam(defaultValue = "20") int pageRowCount,

0 commit comments

Comments
 (0)