Merge pull request #450 from bcgov/bugfix/peach-cronjob

fix(peach-sync): removed npm dependency and fixed in proper indenting in PEACH cronjob yaml

Author: kyle1morel

app/src/controllers/peach.ts

@@ -115,22 +115,22 @@ export const syncPeachRecords = async (): Promise<Permit[]> => {
   );
 
   const records: PeachRecord[] = [];
-  const failures: { index: number; reason: unknown }[] = [];
+  const errors: { index: number; reason: unknown }[] = [];
   results.forEach((result, index) => {
     if (result.status === 'fulfilled') records.push(result.value);
-    else failures.push({ index: index, reason: result.reason });
+    else errors.push({ index: index, reason: result.reason });
   });
 
   log.verbose('PEACH fetch summary', {
     total: results.length,
     fetched: records.length,
-    failed: failures.length
+    errored: errors.length
   });
 
-  if (failures.length) {
-    for (const failure of failures) {
-      const { recordId, systemId } = systemRecordPermits[failure.index];
-      log.warn('PEACH fetch failed', { recordId, systemId, error: failure.reason });
+  if (errors.length) {
+    for (const error of errors) {
+      const { recordId, systemId } = systemRecordPermits[error.index];
+      log.warn('PEACH fetch call error:', { recordId, systemId, error: error.reason });
     }
   }
 

charts/pcns/Chart.yaml

@@ -3,7 +3,7 @@ name: nr-permitconnect-navigator-service
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.0.31
+version: 0.0.32
 kubeVersion: ">= 1.13.0"
 description: PermitConnect Navigator Service
 # A chart can be either an 'application' or a 'library' chart.

charts/pcns/README.md

@@ -1,6 +1,6 @@
 # nr-permitconnect-navigator-service
 
-![Version: 0.0.31](https://img.shields.io/badge/Version-0.0.31-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.9.0](https://img.shields.io/badge/AppVersion-0.9.0-informational?style=flat-square)
+![Version: 0.0.32](https://img.shields.io/badge/Version-0.0.32-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.9.0](https://img.shields.io/badge/AppVersion-0.9.0-informational?style=flat-square)
 
 PermitConnect Navigator Service
 

charts/pcns/templates/peachsynccronjob.yaml

@@ -42,9 +42,9 @@ spec:
             - name: peach-sync
               image: "{{ .Values.image.repository }}/{{ .Chart.Name }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
               imagePullPolicy: {{ .Values.image.pullPolicy }}
-              command: ["sh","-lc"]
-              args:
-                - "npm run peach:sync"
+              command:
+                - /usr/local/bin/node
+                - sbin/peachSync.js
               resources:
                 {{- toYaml .Values.peachSync.resources | nindent 16 }}
               env:
@@ -81,9 +81,9 @@ spec:
                       name: {{ include "pcns.configname" . }}-ches-service-account
                 - name: SERVER_PEACH_CLIENTID
                   valueFrom:
-                  secretKeyRef:
-                    key: username
-                    name: {{ include "pcns.configname" . }}-peach
+                    secretKeyRef:
+                      key: username
+                      name: {{ include "pcns.configname" . }}-peach
                 - name: SERVER_PEACH_CLIENTSECRET
                   valueFrom:
                     secretKeyRef: