Merge pull request #500 from bcgov/feature/db-repos

refactor(api): migrate to controller-service-domain-repository architecture

Author: qhanson55

.vscode/extensions.json

@@ -7,7 +7,6 @@
     "eamodio.gitlens",
     "editorconfig.editorconfig",
     "esbenp.prettier-vscode",
-    "gruntfuggly.todo-tree",
     "lokalise.i18n-ally",
     "redhat.vscode-yaml",
     "ryanluker.vscode-coverage-gutters",

app/app.ts

@@ -1,4 +1,3 @@
-import { Prisma } from '@prisma/client';
 import compression from 'compression';
 import config from 'config';
 import cors from 'cors';
@@ -141,37 +140,6 @@ export function errorHandler(
   if (err instanceof Problem) {
     log.error(err);
     err.send(req, res);
-  } else if (err instanceof Prisma.PrismaClientKnownRequestError) {
-    switch (err.code) {
-      case 'P2002':
-        new Problem(500, {
-          type: err.code,
-          title: err.meta?.constraint as string,
-          detail: err.meta?.modelName as string
-        }).send(req, res);
-        break;
-      case 'P2003':
-        new Problem(500, {
-          type: err.code,
-          title: err.meta?.constraint as string,
-          detail: err.meta?.modelName as string
-        }).send(req, res);
-        break;
-      case 'P2025':
-        new Problem(404, {
-          type: err.code,
-          title: err.meta?.cause as string,
-          detail: err.meta?.modelName as string
-        }).send(req, res);
-        break;
-      default:
-        new Problem(500, {
-          type: err.code,
-          title: err.meta?.cause as string,
-          detail: err.meta?.modelName as string
-        }).send(req, res);
-        break;
-    }
   } else {
     if (err.stack) log.error(err);
     new Problem(500, { detail: err.message ?? err.toString() }).send(req, res);

app/eslint.config.ts

@@ -37,5 +37,29 @@ export default defineConfig([
       quotes: ['error', 'single'],
       semi: ['error', 'always']
     }
+  },
+  // Entity repositories must go through inherited query/mutation methods,
+  // never touch `this.model` directly — that's only for readable.ts/writable.ts
+  // to implement the base methods themselves.
+  {
+    files: ['src/repository/**/*.ts'],
+    rules: {
+      'no-restricted-syntax': [
+        'error',
+        {
+          // eslint-disable-next-line quotes
+          selector: `MemberExpression[object.type='ThisExpression'][property.name='model']`,
+          message:
+            'Use inherited query methods (this.findMany, this.create, etc.) instead of this.model directly. ' +
+            'Only readable.ts/writable.ts may access this.model.'
+        }
+      ]
+    }
+  },
+  {
+    files: ['src/repository/readable.ts', 'src/repository/writable.ts'],
+    rules: {
+      'no-restricted-syntax': 'off'
+    }
   }
 ]);

app/peachSync.ts

@@ -1,6 +1,7 @@
-import { syncPeachRecords } from './src/controllers/peach.ts';
-import { sendPermitUpdateNotifications } from './src/controllers/permit.ts';
+import { syncPeachRecords } from './src/domains/peach.ts';
+import { sendPermitUpdateNotifications } from './src/domains/permit.ts';
 import { refreshCodeCaches } from './src/db/codes/cache.ts';
+import { unitOfWork } from './src/db/unitOfWork.ts';
 import { getLogger } from './src/utils/log.ts';
 import { state } from './state.ts';
 
@@ -11,33 +12,42 @@ const log = getLogger(module.filename);
 async function syncPeachToPcns() {
   if (!state.features.peach) return;
 
-  const started = Date.now();
-  let updatedPermitsWithNotes: UpdatedPermitWithNote[];
+  await unitOfWork.execute(
+    async ({ electrificationProject, generalProject, housingProject, permit, permitNote, user }) => {
+      const started = Date.now();
+      let updatedPermitsWithNotes: UpdatedPermitWithNote[];
 
-  log.info('PEACH sync job started');
-  try {
-    updatedPermitsWithNotes = await syncPeachRecords();
+      log.info('PEACH sync job started');
+      try {
+        updatedPermitsWithNotes = await syncPeachRecords({ permit });
 
-    log.info('PEACH sync completed', {
-      durationMs: Date.now() - started,
-      updatedCount: updatedPermitsWithNotes.length
-    });
-  } catch (error) {
-    log.error('PEACH sync FAILED during data sync', error);
-    process.exitCode = 1;
-    return;
-  }
+        log.info('PEACH sync completed', {
+          durationMs: Date.now() - started,
+          updatedCount: updatedPermitsWithNotes.length
+        });
+      } catch (error) {
+        log.error('PEACH sync FAILED during data sync', error);
+        process.exitCode = 1;
+        return;
+      }
 
-  if (updatedPermitsWithNotes.length === 0) return;
+      if (updatedPermitsWithNotes.length === 0) return;
 
-  try {
-    for (const permitWithNote of updatedPermitsWithNotes) {
-      const { permit, note } = permitWithNote;
-      await sendPermitUpdateNotifications(permit, true, note);
+      try {
+        for (const permitWithNote of updatedPermitsWithNotes) {
+          const { permit, note } = permitWithNote;
+          await sendPermitUpdateNotifications(
+            { electrificationProject, generalProject, housingProject, permitNote, user },
+            permit,
+            true,
+            note
+          );
+        }
+      } catch (error) {
+        log.warn('PEACH sync completed but sending notifications failed', error);
+      }
     }
-  } catch (error) {
-    log.warn('PEACH sync completed but sending notifications failed', error);
-  }
+  );
 }
 
 async function main() {