chore(ci): simplify non-PROD frontend URLs (#2000)

Author: DerekRoberts

.github/workflows/job-nightly.yml

@@ -56,4 +56,4 @@ jobs:
           artifact_name: "zap_frontend"
           cmd_options: "-a"
           issue_title: "ZAP: frontend"
-          target: https://${{ env.PREFIX }}-frontend.${{ env.DOMAIN }}
+          target: https://${{ env.PREFIX }}.${{ env.DOMAIN }}

.github/workflows/pr-validate.yml

@@ -29,7 +29,7 @@ jobs:
     uses: bcgov/quickstart-openshift-helpers/.github/workflows/.pr-validate.yml@0b8121a528aaa05ef8def2f79be9081691dfe98a # v0.9.0
     with:
       markdown_links: |
-        - [Frontend](https://${{ github.event.repository.name }}-${{ needs.init.outputs.mod-tag }}-frontend.apps.silver.devops.gov.bc.ca/)
+        - [Frontend](https://${{ github.event.repository.name }}-${{ needs.init.outputs.mod-tag }}.apps.silver.devops.gov.bc.ca/)
         - [Backend](https://${{ github.event.repository.name }}-${{ github.event.number }}-backend.apps.silver.devops.gov.bc.ca/swagger-ui/index.html)
         - [Oracle-API](https://${{ github.event.repository.name }}-${{ github.event.number }}-oracle-api.apps.silver.devops.gov.bc.ca/actuator/health)
 

frontend/openshift.deploy.yml

@@ -137,7 +137,7 @@ objects:
         app: ${NAME}-${ZONE}
       name: ${NAME}-${ZONE}-${COMPONENT}
     spec:
-      host: ${NAME}-${FAM_MODDED_ZONE}-${COMPONENT}.${DOMAIN}
+      host: ${NAME}-${FAM_MODDED_ZONE}.${DOMAIN}
       port:
         targetPort: 3000-tcp
       to: