Merge branch 'ORV2-5202-Shopping-Cart--Responsive-Design-Needed' of https://github.com/bcgov/onroutebc into ORV2-5202-Shopping-Cart--Responsive-Design-Needed

Author: abhishek-dere

frontend/src/features/permits/constants/stos.ts

@@ -45,9 +45,21 @@ export const STOS_CONDITIONS: PermitCondition[] = [
     conditionLink: "https://www.th.gov.bc.ca/forms/getForm.aspx?formId=1254",
     checked: false
   },
+  {
+    description: "Structure Permit Conditions",
+    condition: "CVSE-1000S",
+    conditionLink: "https://www.th.gov.bc.ca/forms/getForm.aspx?formId=1255",
+    checked: false
+  },
+  {
+    description: "Log Permit Conditions",
+    condition: "CVSE-1000L",
+    conditionLink: "https://www.th.gov.bc.ca/forms/getForm.aspx?formId=1250",
+    checked: false
+  },
 ];
 
-export const MANDATORY_STOS_CONDITIONS: PermitCondition[] = 
+export const MANDATORY_STOS_CONDITIONS: PermitCondition[] =
   STOS_CONDITIONS.filter(
     ({ condition }: PermitCondition) =>
       condition === "CVSE-1000" || condition === "CVSE-1070"

frontend/src/features/permits/helpers/vehicles/subtypes/getEligibleVehicleSubtypes.ts

@@ -1,7 +1,7 @@
 import { Policy } from "onroute-policy-engine";
 
 import { Nullable } from "../../../../../common/types/common";
-import { PermitType } from "../../../types/PermitType";
+import { isTermPermitType, PermitType } from "../../../types/PermitType";
 import { getDefaultRequiredVal } from "../../../../../common/helpers/util";
 import { DEFAULT_EMPTY_SELECT_VALUE } from "../../../../../common/constants/constants";
 
@@ -38,7 +38,10 @@ export const getEligibleVehicleSubtypes = (
       ).keys(),
       ...getDefaultRequiredVal(
         new Map<string, string>(),
-        subtypesMap.get("trailers"),
+        // Only term permits allow trailer subtypes to be used
+        isTermPermitType(permitType)
+          ? subtypesMap.get("trailers")
+          : undefined,
       ).keys(),
     ],
   );

frontend/src/features/permits/pages/Application/components/common/ConditionalLicensingFeeLabel.tsx

@@ -77,6 +77,7 @@ export const ConditionalLicensingFeeLabel = ({
       {link ? (
         <CustomExternalLink
           href={link.link}
+          openInNewTab
           className={classes?.link}
           data-testid={`conditional-licensing-fee-link-${clf}`}
           withLinkIcon={true}

frontend/src/features/permits/pages/Application/components/form/VehicleInformationSection/VehicleDetails.tsx

@@ -91,6 +91,7 @@ export const VehicleDetails = ({
       PERMIT_TYPES.QRFR,
       PERMIT_TYPES.NRSCV,
       PERMIT_TYPES.NRQCV,
+      PERMIT_TYPES.STOS,
     ] as PermitType[]
   ).includes(permitType);
 

frontend/src/features/permits/pages/Application/components/pay/paymentOptions/InPersonPPCPaymentOption.tsx

@@ -152,7 +152,7 @@ export const InPersonPPCPaymentOption = ({
         }}
         label={
           <div className="label__text">
-            In-person at a Provinicial Permit Centre
+            In-person at a Provincial Permit Centre
           </div>
         }
         value={paymentMethod}