Skip to content

Commit 97350e4

Browse files
committed
Using lists for Used entities
1 parent 808b8fd commit 97350e4

File tree

2 files changed

+24
-6
lines changed

2 files changed

+24
-6
lines changed

examples/dcm2niix/README.md

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,16 @@ tree sub-02/
5656

5757
See the `dcm2niix.prov.jsonld` file.
5858

59-
Some limitations :
60-
* for now, the values of Activities `Used` keys only refer to the first dicom file of a series, although each activity should be linked to all the data it actually used (i.e.: all dicom files in a directory in our case).
61-
* as there is a high number of dicom files (384 in `acq1/` and 5460 in `acq2/`), we did not create an entity for each of these. Only the first three files of each directory were represented.
59+
## Limitations
60+
61+
### `Used` key for activities
62+
63+
Although the BIDS-Prov spec mentions:
64+
65+
> Used : OPTIONAL. UUID. Identifier of an entity used by this activity (the corresponding Entity must be defined with its own Entity record).
66+
67+
We added entities as a list in to link all the dicom files of a directory to the corresponding conversion activity.
68+
69+
### High number of dicom files
70+
71+
As there is a high number of dicom files (384 in `acq1/` and 5460 in `acq2/`), we did not create an entity for each of these. Only the first three files of each directory were represented.

examples/dcm2niix/dcm2niix.prov.jsonld

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
],
1212
"Software": [
1313
{
14-
"Id": "urn:dcm2niix",
14+
"Id": "urn:dcm2niix-4a586b50",
1515
"Label": "dcm2niix",
1616
"Version": "v1.0.20220720"
1717
}
@@ -22,14 +22,22 @@
2222
"Label": "Conversion",
2323
"Command": "dcm2niix -o . -f sub-%i/ses-%t/anat/sub-%i_ses-%t_T1w sourcedata/acq1/dicoms/example-dicom-structural-master/dicoms/",
2424
"AssociatedWith": "urn:dcm2niix-4a586b50",
25-
"Used": "bids::sourcedata/hirni-demo/acq1/dicoms/example-dicom-structural-master/dicoms/N2D_0001.dcm"
25+
"Used": [
26+
"bids::sourcedata/hirni-demo/acq1/dicoms/example-dicom-structural-master/dicoms/N2D_0001.dcm",
27+
"bids::sourcedata/hirni-demo/acq1/dicoms/example-dicom-structural-master/dicoms/N2D_0002.dcm",
28+
"bids::sourcedata/hirni-demo/acq1/dicoms/example-dicom-structural-master/dicoms/N2D_0003.dcm"
29+
]
2630
},
2731
{
2832
"Id": "urn:conversion-5a66f5be",
2933
"Label": "Conversion",
3034
"Command": "dcm2niix -o . -f sub-%i/ses-%t/func/sub-%i_ses-%t_task-oneback_run-1_bold sourcedata/acq1/dicoms/example-dicom-structural-master/dicoms/",
3135
"AssociatedWith": "urn:dcm2niix-4a586b50",
32-
"Used": "bids::sourcedata/hirni-demo/acq2/dicoms/example-dicom-functional-master/dicoms/MR.1.3.46.670589.11.38317.5.0.4476.2014042516042547586"
36+
"Used": [
37+
"bids::sourcedata/hirni-demo/acq2/dicoms/example-dicom-functional-master/dicoms/MR.1.3.46.670589.11.38317.5.0.4476.2014042516042547586",
38+
"bids::sourcedata/hirni-demo/acq2/dicoms/example-dicom-functional-master/dicoms/MR.1.3.46.670589.11.38317.5.0.4476.2014042516042548588",
39+
"bids::sourcedata/hirni-demo/acq2/dicoms/example-dicom-functional-master/dicoms/MR.1.3.46.670589.11.38317.5.0.4476.2014042516042551590"
40+
]
3341
}
3442
],
3543
"Entities": [

0 commit comments

Comments
 (0)