chore: add rpc urls validation

Author: Filipp Makarov

foundry.toml

@@ -77,9 +77,9 @@
   optimism = { key = "${ETHERSCAN_API_KEY}", url = "https://api.etherscan.io/api", chain = "10"}
   optimism-sepolia = { key = "${ETHERSCAN_API_KEY}", url = "https://api.etherscan.io/api", chain = "11155420"}
 
-  # BSC
-  bsc = { key = "${ETHERSCAN_API_KEY}", url = "https://api.etherscan.io/api", chain = "56"}
-  bsc-testnet = { key = "${ETHERSCAN_API_KEY}", url = "https://api.etherscan.io/api", chain = "97"}
+  # BNB
+  bnb = { key = "${ETHERSCAN_API_KEY}", url = "https://api.etherscan.io/api", chain = "56"}
+  bnb-testnet = { key = "${ETHERSCAN_API_KEY}", url = "https://api.etherscan.io/api", chain = "97"}
 
   # SONIC
   sonic = { key = "${ETHERSCAN_API_KEY}", url = "https://api.etherscan.io/api", chain = "146"}
@@ -143,4 +143,4 @@
   # arc-testnet = { key = "", url = "", chain = "1244"}
 
   # SOPHON
-  # sophon-zk-testnet = { key = "", url = "", chain = "531050204"} 
+  sophon-zk-testnet = { key = "", url = "https://block-explorer-api.zksync-os-testnet-sophon.zksync.dev/api", chain = "531050204"} 

script/deploy/DeployStxContracts.s.sol

@@ -76,16 +76,21 @@ contract DeployStxContracts is Script, Config {
      * @param contractNames Array of contract names to deploy (empty array = all contracts)
      */
     function run(uint256 chainId, string[] memory contractNames) external {
-        // Load configuration and setup forks (enable write-back to save deployed addresses)
+        
         string memory fullConfigPath = string.concat(vm.projectRoot(), configPath);
         console.log("Loading config from:", fullConfigPath);
-        _loadConfigAndForks(fullConfigPath, true);
+        
+        // load config
+        _loadConfig(fullConfigPath, false);
 
-        // Load configuration for each chain
-        loadConfigurations(chainId, contractNames);
-
-        // Move above to the base contract
+        // create fork
+        console.log("Creating fork for chain:", chainId);
+        uint256 forkId = vm.createFork(config.getRpcUrl(chainId));
+        forkOf[chainId] = forkId;
+        console.log("Fork successfully created");
 
+        // Load configuration for each chain
+        loadConfiguration(chainId);
         deployContracts(chainId, contractNames);
     }
 
@@ -170,11 +175,12 @@ contract DeployStxContracts is Script, Config {
         console.log("Chain ID:", chainId);
         console.log("=====================================\n");
 
-        // Use the RPC_{chainId} environment variable directly
-        string memory rpcUrl = vm.envString(string.concat("RPC_", vm.toString(chainId)));
 
+        // Fallback flow of creating a fork not via config but from .env file
+        // Use the RPC_{chainId} environment variable directly
+        // string memory rpcUrl = vm.envString(string.concat("RPC_", vm.toString(chainId)));
         // Create and switch to fork for the chain
-        vm.createSelectFork(rpcUrl);
+        // vm.createSelectFork(rpcUrl);
 
         // Verify chain ID
         require(block.chainid == chainId, "Chain ID mismatch");
@@ -310,9 +316,9 @@ contract DeployStxContracts is Script, Config {
     // ============
 
     /**
-     * @notice Load configurations for all target chains
+     * @notice Load configurations for a given chain
      */
-    function loadConfigurations(uint256 chainId, string[] memory contractNames) internal {
+    function loadConfiguration(uint256 chainId) internal {
         // Switch to the fork for this chain (already created by _loadConfigAndForks)
         vm.selectFork(forkOf[chainId]);
 

script/deploy/artifacts/ComposableExecutionModule/ComposableExecutionModule.json

@@ -179,10 +179,10 @@ chain_id = 11155420
 name = "Optimism Sepolia"
 
 # ===============
-# BSC
+# BNB
 # ===============
 
-### BSC Mainnet (56)
+### BNB Mainnet (56)
 [56]
 endpoint_url = "${RPC_56}"
 
@@ -194,9 +194,9 @@ verify = true
 chain_id = 56
 
 [56.string]
-name = "BSC Mainnet"
+name = "BNB Mainnet"
 
-### BSC Testnet (97)
+### BNB Testnet (97)
 [97]
 endpoint_url = "${RPC_97}"
 
@@ -208,7 +208,7 @@ verify = true
 chain_id = 97
 
 [97.string]
-name = "BSC Testnet"
+name = "BNB Testnet"
 
 # ===============
 # SONIC

script/deploy/artifacts/K1MeeValidator/K1MeeValidator.json

@@ -110,15 +110,6 @@ if [ -z "$TESTNET_PRIVATE_KEY" ]; then
     exit 1
 fi
 
-# Check RPC URLs for requested chains
-for chain_id in "${REQUESTED_CHAINS[@]}"; do
-    RPC_VAR="RPC_${chain_id}"
-    if [ -z "${!RPC_VAR}" ]; then
-        log_error "$RPC_VAR is not set in .env for chain $chain_id"
-        log_info "Please set $RPC_VAR in your .env file"
-        exit 1
-    fi
-done
 
 # Check if CREATEX_ADDRESS is set in .env
 if [ -z "$CREATEX_ADDRESS" ]; then
@@ -132,6 +123,40 @@ if [ -z "$EXPECTED_DISPERSE_ADDRESS" ]; then
     exit 1
 fi
 
+
+log_info "Checking RPC URLs for the requested chains..."
+# Check RPC URLs for requested chains
+for chain_id in "${REQUESTED_CHAINS[@]}"; do
+    RPC_VAR="RPC_${chain_id}"
+    if [ -z "${!RPC_VAR}" ]; then
+        log_error "$RPC_VAR is not set in .env for chain $chain_id"
+        log_info "Please set $RPC_VAR in your .env file"
+        exit 1
+    fi
+done
+
+log_info "Trying to create forks for the requested chains..."
+# Build the chain array in the format Solidity expects: [1,10,137]
+CHAIN_ARRAY="["
+for i in "${!REQUESTED_CHAINS[@]}"; do
+    if [ $i -gt 0 ]; then
+        CHAIN_ARRAY="${CHAIN_ARRAY},"
+    fi
+    CHAIN_ARRAY="${CHAIN_ARRAY}${REQUESTED_CHAINS[$i]}"
+done
+CHAIN_ARRAY="${CHAIN_ARRAY}]"
+
+# Try to create forks for the requested chains
+{ 
+    forge script ./util/ValidateForks.s.sol:ValidateForks --sig "run(uint256[])" "$CHAIN_ARRAY" 1> ./deploy-logs/validate-forks.log 2> ./deploy-logs/validate-forks-errors.log 
+} || {
+    log_error "Failed to create forks for the requested chains, see logs for more details"
+    log_error "The reason is most likely that some of the RPC URL for the chains you are about to deploy to is not valid"
+    exit 1
+}
+
+log_info "Forks successfully created, all RPC's from config are accessible"
+
 # Check if we have to recompile the artifacts
 export FOUNDRY_PROFILE="via-ir"
 read -r -p "Do you want to rebuild Stx-contracts artifacts from your local sources? (y/n): " proceed
@@ -183,15 +208,6 @@ else
     log_info "Using precompiled artifacts"
 fi
 
-CHAIN_ARRAY="["
-for i in "${!REQUESTED_CHAINS[@]}"; do
-    if [ $i -gt 0 ]; then
-        CHAIN_ARRAY="${CHAIN_ARRAY},"
-    fi
-    CHAIN_ARRAY="${CHAIN_ARRAY}${REQUESTED_CHAINS[$i]}"
-done
-CHAIN_ARRAY="${CHAIN_ARRAY}]"
-
 # Check the expected addresses for the contracts and record the bytecode hashes
 log_info "Getting expected addresses for the contracts..."
 {