chore: forge linting

Author: Filipp Makarov

contracts/lib/nexus/ProxyLib.sol

@@ -57,13 +57,14 @@ library ProxyLib {
         returns (address payable predictedAddress)
     {
         // Get the init code hash
-        /// forge-lint:disable-next-line(asm-keccak256)
+        /// forge-lint:disable-start(asm-keccak256)
         bytes32 initCodeHash = keccak256(
             abi.encodePacked(
                 type(NexusProxy).creationCode,
                 abi.encode(implementation, abi.encodeCall(INexus.initializeAccount, initData))
             )
         );
+        /// forge-lint:disable-end(asm-keccak256)
 
         // Compute the predicted address
         predictedAddress = payable(address(

contracts/lib/stx-validator/validation-modes/SimpleValidatorLib.sol

@@ -68,8 +68,8 @@ library SimpleValidatorLib {
             return SIG_VALIDATION_FAILED;
         }
 
-        /// forge-lint:disable-next-line(unsafe-typecast)
         /// timestamps are never big enough to overflow uint48
+        /// forge-lint:disable-next-line(unsafe-typecast)
         return _packValidationData(false, uint48(upperBoundTimestamp), uint48(lowerBoundTimestamp));
     }
 

contracts/lib/stx-validator/validation-modes/TxValidatorLib.sol

@@ -327,8 +327,10 @@ library TxValidatorLib {
         if (v >= EIP_155_MIN_V_VALUE) {
             return uint8((v - 2 * _extractChainIdFromV(v) - 35) + 27);
         } else if (v <= 1) {
+            /// forge-lint:disable-next-line(unsafe-typecast)
             return uint8(v + 27);
         } else {
+            /// forge-lint:disable-next-line(unsafe-typecast)
             return uint8(v);
         }
     }

contracts/nexus/Nexus.sol

@@ -412,6 +412,7 @@ contract Nexus is INexus, BaseAccount, ExecutionHelper, ModuleManager, UUPSUpgra
         // Handle potential ERC7739 support detection request
         if (signature.length == 0) {
             // Forces the compiler to optimize for smaller bytecode size.
+            /// forge-lint:disable-next-line(divide-before-multiplModuleManager.sol:716:16y)
             if (uint256(hash) == (~signature.length / 0xffff) * 0x7739) {
                 return _checkERC7739Support(hash, signature);
             }
@@ -453,6 +454,7 @@ contract Nexus is INexus, BaseAccount, ExecutionHelper, ModuleManager, UUPSUpgra
         || MODULE_TYPE_PREVALIDATION_HOOK_ERC4337 || MODULE_TYPE_MULTI */
         // Bitmap: 0x31F represents supported module types: 0,1,2,3,4,8,9
         // 0x31F = 0b1100011111 = (1<<0)|(1<<1)|(1<<2)|(1<<3)|(1<<4)|(1<<8)|(1<<9)
+        /// forge-lint:disable-next-line(incorrect-shift)
         return ((1 << moduleTypeId) & 0x31F) != 0;
     }
 
@@ -556,6 +558,7 @@ contract Nexus is INexus, BaseAccount, ExecutionHelper, ModuleManager, UUPSUpgra
         returns (bytes4)
     {
         bytes4 support = IValidator(validator).isValidSignatureWithSender(msg.sender, hash, signature);
+        /// forge-lint:disable-next-line(unsafe-typecast)
         if (bytes2(support) == bytes2(SUPPORTS_ERC7739) && support > prevResult) {
             return support;
         }

contracts/node-pm/NodePaymasterFactory.sol

@@ -102,6 +102,7 @@ contract NodePaymasterFactory {
             mstore(add(ptr, 0x35), initCodeHash)
             predictedAddress := keccak256(ptr, 0x55)
         }
+        /// forge-lint:disable-next-line(unsafe-typecast)
         return payable(address(uint160(predictedAddress)));
     }