rules: finish renaming module_base_from_va_bits to loongarch64_module_base

The file moved but the name it is keyed by did not. check-rule-registry
requires a rule's symbol to match its filename, and the confidence-floor
allowlist is keyed by basename, so both failed: an unregistered rule and
an orphan registry entry on one side, an unreviewed pin and a stale
allowlist entry on the other.

Author: bcoles

src/components/proc_cpuinfo.c

@@ -210,7 +210,7 @@ static int detect_ppc64_mmu(void) {
  * What it is NOT is the shift. The field and the printed line differ by one:
  * cpu_vabits is VALEN and M is VALEN + 1, so a consumer placing a region at
  * `0 - (1 << M)` lands a full bit low. SF_VIRT_ADDR_BITS carries the width, and
- * a consumer that needs the shift subtracts one -- module_base_from_va_bits is
+ * a consumer that needs the shift subtracts one -- loongarch64_module_base is
  * the one that does.
  *
  * Note also that an mmap boundary probe CANNOT substitute for this read.

src/engine_rules.c

@@ -84,7 +84,7 @@ static const rule_fn k_rules[] = {
     rule_module_base_bounds,
     rule_module_base_execmem_window,
     rule_module_base_from_text,
-    rule_module_base_from_va_bits,
+    rule_loongarch64_module_base,
     rule_module_base_ppc64_vmalloc,
 
     /* Multi-entry EFI_LOADER_CODE → Q_PHYS_IMAGE_BASE pin */

src/include/kasld/engine_rules.h

@@ -330,7 +330,7 @@ R(module_text_bracket);
 R(module_base_bounds);
 R(module_base_execmem_window);
 R(module_base_from_text);
-R(module_base_from_va_bits);
+R(loongarch64_module_base);
 R(module_base_ppc64_vmalloc);
 
 /* Multi-entry EFI_LOADER_CODE → Q_PHYS_IMAGE_BASE pin (arm64/riscv64/x86_64) */

src/rules/loongarch64_module_base.c

@@ -38,9 +38,9 @@
 
 #include <string.h>
 
-int rule_module_base_from_va_bits(const struct evidence_set *ev,
-                                  const struct estimate *est,
-                                  struct constraint *out, int out_max) {
+int rule_loongarch64_module_base(const struct evidence_set *ev,
+                                 const struct estimate *est,
+                                 struct constraint *out, int out_max) {
 #if defined(MODULES_BASE_LOONGARCH64_PCI_IOSIZE)
   (void)est;
   if (out_max < 1)
@@ -85,7 +85,7 @@ int rule_module_base_from_va_bits(const struct evidence_set *ev,
   }
   if (psrc && c->lineage_count < MAX_LINEAGE)
     c->derived_from[c->lineage_count++] = psrc;
-  snprintf(c->origin, ORIGIN_LEN, "module_base_from_va_bits");
+  snprintf(c->origin, ORIGIN_LEN, "loongarch64_module_base");
   return 1;
 #else
   (void)ev;

tests/check-confidence-floor

@@ -103,7 +103,7 @@ RULES=$ROOT/src/rules
 #                                 KASLR_*_ALIGN is the MINIMUM over every config
 #                                 it admits -- a value taken from one config is
 #                                 too coarse and excludes the finer-aligned bases
-#   module_base_from_va_bits      computed: vm_map_base + addend + pages. The
+#   loongarch64_module_base       computed: vm_map_base + addend + pages. The
 #                                 shift is the width the KERNEL places the region
 #                                 with, which is not always the width cpuinfo
 #                                 reports (SHIFT_BIAS), and the page term follows
@@ -172,7 +172,7 @@ directmap_kaslr_disabled_pin
 efi_loader_kernel_pick
 initrd_phys_exclude
 kaslr_align_arch_default
-module_base_from_va_bits
+loongarch64_module_base
 module_base_ppc64_vmalloc
 page_offset_from_config
 page_offset_from_leak

tests/test_engine.c

@@ -7780,9 +7780,9 @@ static void test_module_base_from_text(void) {
  * width as CPUCFG1.VALEN + 1 while vm_map_base shifts by VALEN, so a reported
  * 48 places the region at -(1 << 47); the 2-page term follows the kernel's page
  * size, not the analysing build's. */
-static void test_module_base_from_va_bits(void) {
+static void test_loongarch64_module_base(void) {
   struct engine e;
-  const rule_fn rules[] = {rule_module_base_from_va_bits};
+  const rule_fn rules[] = {rule_loongarch64_module_base};
   struct estimate top;
   quantities[Q_MODULE_BASE].init_top(&top);
 
@@ -8766,7 +8766,7 @@ int main(void) {
   RUN(test_module_base_band_bounds);
   RUN(test_module_base_execmem_window);
   RUN(test_module_base_from_text);
-  RUN(test_module_base_from_va_bits);
+  RUN(test_loongarch64_module_base);
   RUN(test_module_base_ppc64_vmalloc);
 
   BEGIN_CATEGORY("EFI Loader Code disambiguation");