Skip to content

Commit 871a7a5

Browse files
committed
render: tighten Phys/Virt coupling note in default readout
Collapse the coupling note to a single dim line that closes the bounds table. It is a static arch property, not a measured quantity, so it now recedes from the green/magenta rows and sits flush under them rather than in its own blank-fenced block. Drop the redundant second sentence on decoupled arches ("a phys leak does NOT reveal the virt text base" — already implied by "independently"), spell out physical/virtual in the descriptions, and label the row "Phys/Virt Coupling" so it self-documents.
1 parent 5e505a4 commit 871a7a5

1 file changed

Lines changed: 8 additions & 6 deletions

File tree

src/render/text.c

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1059,8 +1059,8 @@ static void print_memory_map(void) {
10591059
*/
10601060
static const char *coupling_descr(void) {
10611061
return TEXT_TRACKS_DIRECTMAP
1062-
? "virt and phys text move together (coupled)"
1063-
: "virt and phys text are independent on this arch";
1062+
? "physical and virtual text move together (coupled)"
1063+
: "physical and virtual text randomize independently";
10641064
}
10651065

10661066
/* Emit one bound row of the readout. `label` is the left column; the
@@ -1317,10 +1317,12 @@ static void render_readout(const struct summary *s) {
13171317
}
13181318
}
13191319

1320-
printf("\n %-19s %s.\n", "Coupling", coupling_descr());
1321-
#if !TEXT_TRACKS_DIRECTMAP
1322-
printf(" %-19s A phys leak does NOT reveal the virt text base.\n", "");
1323-
#endif
1320+
/* Coupling closes the bounds table as a single dim line: it is a static
1321+
* arch property (not a measured quantity), so it recedes from the green/
1322+
* magenta measured rows and explains why physical and virtual bases resolve
1323+
* as separate (or shared) quantities above. */
1324+
printf(" %-19s %s%s%s\n", "Phys/Virt coupling", c(C_DIM), coupling_descr(),
1325+
c(C_RESET));
13241326
printf("\n");
13251327

13261328
readout_print_leaks();

0 commit comments

Comments
 (0)