Skip to content

Commit 9d60029

Browse files
committed
check-results: stop failing cmdline_memmap for sitting outside RAM
memmap= regions were classified with the DRAM-resident ones, so any that fell outside the System RAM extents was reported as a failure. That is the normal case rather than an error: cmdline_memmap emits a region only for the memmap= forms that REMOVE address space from RAM -- $ reserved, ! persistent memory, # ACPI NVS -- and never for the @ form that adds usable RAM, so every interval it produces is a carve-out naming whatever the operator asked to reserve. Those routinely sit above the top of memory, as a ramoops or an emulated-pmem region does. It joins the regions already allowed to lie outside the extents. A memmap= interval that does fall within RAM still passes, and no other region's containment check is relaxed.
1 parent 1c40df1 commit 9d60029

1 file changed

Lines changed: 8 additions & 1 deletion

File tree

extra/check-results

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -711,8 +711,15 @@ printf '%s\n' "$tagged_lines" | while IFS= read -r line; do
711711
# Some regions (efi_memmap, acpi_*) may sit in reserved holes
712712
# outside the System RAM extents. Don't fail those — skip with a
713713
# note so the operator can spot-check.
714+
#
715+
# cmdline_memmap is not a hole but a carve-out: the component emits a
716+
# region only for the memmap= forms that REMOVE address space from RAM
717+
# ($ reserved, ! persistent memory, # ACPI NVS), never for the @ form
718+
# that adds usable RAM. Those intervals name whatever the operator
719+
# asked to reserve, which is routinely outside the RAM extents
720+
# entirely — a ramoops or pmem region above the top of memory.
714721
case "$region" in
715-
efi_memmap|acpi_table|acpi_nvs|reserved_mem|pmem)
722+
efi_memmap|acpi_table|acpi_nvs|reserved_mem|pmem|cmdline_memmap)
716723
skip "$desc — outside System RAM (region may be in reserved hole)"
717724
;;
718725
*)

0 commit comments

Comments
 (0)