Skip to content

Commit d6625f5

Browse files
committed
build: install the tools the CI lint guards need
Several lint guards run by `make check` soft-skip when their tool is absent, so an unprovisioned tool reads as a passing check while the guard never runs. On the CI runner check-fdt-unflatten (dtc), check-fuzz-harnesses (clang), and the check-manpages roff lint (groff) were all silently skipping -- device-tree-compiler and groff are absent from the base image, and clang ran only by accident. Install device-tree-compiler, python3, clang, and groff beside the existing shellcheck, jq, and libxml2-utils so every guard the build gate believes it runs actually runs.
1 parent db12100 commit d6625f5

1 file changed

Lines changed: 11 additions & 4 deletions

File tree

.github/workflows/build.yml

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,17 @@ jobs:
1313
- uses: actions/checkout@v6
1414

1515
- name: Install dependencies
16-
# shellcheck lets `make check`'s lint guards run tests/check-shellcheck
17-
# over all shipped shell scripts (extra/ + tests/); it soft-skips when absent.
18-
# jq lets tests/validate-fixtures run extra/validate-bundle; it soft-skips too.
19-
run: sudo apt-get update && sudo apt-get install -y zlib1g-dev gcc-i686-linux-gnu shellcheck jq libxml2-utils
16+
# Each guard below soft-skips when its tool is absent, so an unprovisioned
17+
# tool reads as "clean" while the check silently never runs. Install them
18+
# so `make check`'s lint gate is real:
19+
# shellcheck check-shellcheck over all shipped shell scripts
20+
# jq validate-fixtures -> extra/validate-bundle
21+
# libxml2-utils check-diagram-data (xmllint over the SVGs)
22+
# device-tree-compiler check-fdt-unflatten (builds a DTB with dtc)
23+
# python3 check-fdt-unflatten / hardening-fixtures helpers
24+
# clang check-fuzz-harnesses (a -fsanitize=fuzzer compiler)
25+
# groff check-manpages (roff lint of the man pages)
26+
run: sudo apt-get update && sudo apt-get install -y zlib1g-dev gcc-i686-linux-gnu shellcheck jq libxml2-utils device-tree-compiler python3 clang groff
2027

2128
- name: Build
2229
run: make

0 commit comments

Comments
 (0)