fix(post_dispatch): register types.proto before tx.proto to fix Amino JSON signing

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: rootulp

x/core/02_post_dispatch/types/amino_json_test.go

@@ -0,0 +1,96 @@
+package types_test
+
+import (
+	"context"
+	"testing"
+
+	"github.com/stretchr/testify/require"
+
+	txv1beta1 "cosmossdk.io/api/cosmos/tx/v1beta1"
+	"cosmossdk.io/math"
+	"cosmossdk.io/x/tx/signing"
+	"cosmossdk.io/x/tx/signing/aminojson"
+
+	"github.com/bcp-innovations/hyperlane-cosmos/util"
+	"github.com/bcp-innovations/hyperlane-cosmos/x/core/02_post_dispatch/types"
+
+	gogoproto "github.com/cosmos/gogoproto/proto"
+	"google.golang.org/protobuf/proto"
+	"google.golang.org/protobuf/types/known/anypb"
+)
+
+// TestAminoJSONSigningMsgSetDestinationGasConfig reproduces the bug where Amino
+// JSON signing fails for MsgSetDestinationGasConfig because the nested
+// DestinationGasConfig message's field descriptors are not resolvable via
+// gogoproto.HybridResolver.
+//
+// See: https://github.com/bcp-innovations/hyperlane-cosmos/issues/156
+func TestAminoJSONSigningMsgSetDestinationGasConfig(t *testing.T) {
+	// 1. Construct a MsgSetDestinationGasConfig with a populated DestinationGasConfig
+	igpId := util.CreateMockHexAddress("igp", 1)
+
+	msg := &types.MsgSetDestinationGasConfig{
+		Owner: "cosmos1testowner",
+		IgpId: igpId,
+		DestinationGasConfig: &types.DestinationGasConfig{
+			RemoteDomain: 42,
+			GasOracle: &types.GasOracle{
+				TokenExchangeRate: math.NewInt(1000000000),
+				GasPrice:          math.NewInt(100),
+			},
+			GasOverhead: math.NewInt(50000),
+		},
+	}
+
+	// 2. Marshal with gogo proto
+	msgBytes, err := gogoproto.Marshal(msg)
+	require.NoError(t, err)
+
+	// 3. Wrap as an anypb.Any
+	anyMsg := &anypb.Any{
+		TypeUrl: "/" + gogoproto.MessageName(msg),
+		Value:   msgBytes,
+	}
+
+	// 4. Build a TxBody and marshal to bodyBytes
+	body := &txv1beta1.TxBody{
+		Messages: []*anypb.Any{anyMsg},
+	}
+	bodyBytes, err := proto.Marshal(body)
+	require.NoError(t, err)
+
+	// 5. Build a minimal AuthInfo with a Fee and marshal to authInfoBytes
+	authInfo := &txv1beta1.AuthInfo{
+		Fee: &txv1beta1.Fee{
+			GasLimit: 200000,
+		},
+	}
+	authInfoBytes, err := proto.Marshal(authInfo)
+	require.NoError(t, err)
+
+	// 6. Create an amino JSON sign mode handler with default options
+	// (uses gogoproto.HybridResolver, same as the real app)
+	handler := aminojson.NewSignModeHandler(aminojson.SignModeHandlerOptions{})
+
+	signerData := signing.SignerData{
+		Address:       "cosmos1testowner",
+		ChainID:       "test-chain",
+		AccountNumber: 1,
+		Sequence:      0,
+	}
+
+	txData := signing.TxData{
+		Body:          body,
+		AuthInfo:      authInfo,
+		BodyBytes:     bodyBytes,
+		AuthInfoBytes: authInfoBytes,
+	}
+
+	// 7. Call GetSignBytes — this is where the bug manifests.
+	// The handler internally calls RejectUnknownFields which descends into the
+	// nested DestinationGasConfig message and fails because its field descriptors
+	// are not properly registered in the google.golang.org/protobuf registry.
+	signBytes, err := handler.GetSignBytes(context.Background(), signerData, txData)
+	require.NoError(t, err, "GetSignBytes should succeed for MsgSetDestinationGasConfig")
+	require.NotEmpty(t, signBytes)
+}

x/core/02_post_dispatch/types/proto_init.go

@@ -0,0 +1,23 @@
+package types
+
+import proto "github.com/cosmos/gogoproto/proto"
+
+// This file ensures types.proto is registered before tx.proto.
+//
+// Go runs init() functions in alphabetical file order. Since "tx" sorts before
+// "types", tx.pb.go's init registers tx.proto first. tx.proto references the
+// DestinationGasConfig message from types.proto, but types.proto isn't in the
+// registry yet, so DestinationGasConfig becomes a placeholder with 0 fields.
+// This breaks Amino JSON signing because RejectUnknownFields sees the 0-field
+// placeholder and rejects all DestinationGasConfig fields as unknown.
+//
+// This file ("proto_init.go") sorts before "tx.pb.go" ('p' < 't'), so its
+// init() runs first and registers types.proto. When tx.pb.go's init() runs
+// next, DestinationGasConfig resolves correctly from the registry.
+//
+// fileDescriptor_d8f5bab7d9705187 is a package-level []byte var in types.pb.go.
+// Go initializes all package-level variables before any init() functions, so it
+// is available here.
+func init() {
+	proto.RegisterFile("hyperlane/core/post_dispatch/v1/types.proto", fileDescriptor_d8f5bab7d9705187)
+}