Skip to content

Commit daabf6e

Browse files
fix: amino name typos (#123)
Co-authored-by: Max <72022235+mbreithecker@users.noreply.github.com>
1 parent da156d4 commit daabf6e

6 files changed

Lines changed: 144 additions & 149 deletions

File tree

proto/hyperlane/core/interchain_security/v1/tx.proto

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ message MsgCreateMessageIdMultisigIsmResponse {
7070
];
7171
}
7272

73-
// MsgCreateMultisigIsm ...
73+
// MsgCreateMerkleRootMultisigIsm ...
7474
message MsgCreateMerkleRootMultisigIsm {
7575
option (cosmos.msg.v1.signer) = "creator";
7676
option (amino.name) = "hyperlane/v1/MsgCreateMerkleRootMultisigIsm";
@@ -86,7 +86,7 @@ message MsgCreateMerkleRootMultisigIsm {
8686
uint32 threshold = 3;
8787
}
8888

89-
// MsgCreateMultisigIsmResponse ...
89+
// MsgCreateMerkleRootMultisigIsmResponse ...
9090
message MsgCreateMerkleRootMultisigIsmResponse {
9191
string id = 1 [
9292
(gogoproto.customtype) =
@@ -165,8 +165,7 @@ message MsgCreateRoutingIsmResponse {
165165
// MsgSetRoutingIsmDomain ...
166166
message MsgSetRoutingIsmDomain {
167167
option (cosmos.msg.v1.signer) = "owner";
168-
option (amino.name) =
169-
"hyperlane/v1/MsgCreateRoMsgSetRoutingIsmDomainutingIsm";
168+
option (amino.name) = "hyperlane/v1/MsgSetRoutingIsmDomain";
170169

171170
// ism_id ...
172171
string ism_id = 1 [

proto/hyperlane/core/post_dispatch/v1/tx.proto

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ service Msg {
4141
// MsgCreateIgp ...
4242
message MsgCreateIgp {
4343
option (cosmos.msg.v1.signer) = "owner";
44-
option (amino.name) = "hyperlane/v1/MsgCreateInterchainGasPaymaster";
44+
option (amino.name) = "hyperlane/v1/MsgCreateIgp";
4545

4646
// owner is the message sender.
4747
string owner = 1 [ (cosmos_proto.scalar) = "cosmos.AddressString" ];
@@ -81,7 +81,7 @@ message MsgSetIgpOwner {
8181
bool renounce_ownership = 4;
8282
}
8383

84-
// MsgCreateIgpResponse ...
84+
// MsgSetIgpOwnerResponse ...
8585
message MsgSetIgpOwnerResponse {}
8686

8787
// MsgSetDestinationGasConfig ...
@@ -164,7 +164,7 @@ message MsgClaim {
164164
// MsgClaimResponse ...
165165
message MsgClaimResponse {}
166166

167-
// MsgMerkleTreeHook ...
167+
// MsgCreateMerkleTreeHook ...
168168
message MsgCreateMerkleTreeHook {
169169
option (cosmos.msg.v1.signer) = "owner";
170170
option (amino.name) = "hyperlane/v1/MsgCreateMerkleTreeHook";
@@ -188,16 +188,16 @@ message MsgCreateMerkleTreeHookResponse {
188188
];
189189
}
190190

191-
// MsgMerkleTreeHook ...
191+
// MsgCreateNoopHook ...
192192
message MsgCreateNoopHook {
193193
option (cosmos.msg.v1.signer) = "owner";
194-
option (amino.name) = "hyperlane/v1/MsgCreateMerkleTreeHook";
194+
option (amino.name) = "hyperlane/v1/MsgCreateNoopHook";
195195

196196
// sender ...
197197
string owner = 1 [ (cosmos_proto.scalar) = "cosmos.AddressString" ];
198198
}
199199

200-
// MsgCreateMerkleTreeHookResponse ...
200+
// MsgCreateNoopHookResponse ...
201201
message MsgCreateNoopHookResponse {
202202
string id = 1 [
203203
(gogoproto.customtype) =

x/core/01_interchain_security/module.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ func RegisterLegacyAminoCodec(cdc *codec.LegacyAmino) {
3535
cdc.RegisterConcrete(&types.MsgCreateMerkleRootMultisigIsm{}, "hyperlane/v1/MsgCreateMerkleRootMultisigIsm", nil)
3636
cdc.RegisterConcrete(&types.MsgCreateNoopIsm{}, "hyperlane/v1/MsgCreateNoopIsm", nil)
3737
cdc.RegisterConcrete(&types.MsgCreateRoutingIsm{}, "hyperlane/v1/MsgCreateRoutingIsm", nil)
38-
cdc.RegisterConcrete(&types.MsgSetRoutingIsmDomain{}, "hyperlane/v1/MsgCreateRoMsgSetRoutingIsmDomainutingIsm", nil)
38+
cdc.RegisterConcrete(&types.MsgSetRoutingIsmDomain{}, "hyperlane/v1/MsgSetRoutingIsmDomain", nil)
3939
cdc.RegisterConcrete(&types.MsgRemoveRoutingIsmDomain{}, "hyperlane/v1/MsgRemoveRoutingIsmDomain", nil)
4040
cdc.RegisterConcrete(&types.MsgUpdateRoutingIsmOwner{}, "hyperlane/v1/MsgUpdateRoutingIsmOwner", nil)
4141
}

x/core/01_interchain_security/types/tx.pb.go

Lines changed: 66 additions & 67 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x/core/02_post_dispatch/module.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,10 @@ func RegisterQueryService(server grpc.Server, queryServer types.QueryServer) {
3131
// RegisterLegacyAminoCodec registers the mailbox module's types on the LegacyAmino codec.
3232
func RegisterLegacyAminoCodec(cdc *codec.LegacyAmino) {
3333
cdc.RegisterConcrete(&types.MsgClaim{}, "hyperlane/v1/MsgClaim", nil)
34-
cdc.RegisterConcrete(&types.MsgCreateIgp{}, "hyperlane/v1/MsgCreateInterchainGasPaymaster", nil)
34+
cdc.RegisterConcrete(&types.MsgCreateIgp{}, "hyperlane/v1/MsgCreateIgp", nil)
3535
cdc.RegisterConcrete(&types.MsgCreateMerkleTreeHook{}, "hyperlane/v1/MsgCreateMerkleTreeHook", nil)
36+
cdc.RegisterConcrete(&types.MsgCreateNoopHook{}, "hyperlane/v1/MsgCreateNoopHook", nil)
3637
cdc.RegisterConcrete(&types.MsgPayForGas{}, "hyperlane/v1/MsgPayForGas", nil)
3738
cdc.RegisterConcrete(&types.MsgSetDestinationGasConfig{}, "hyperlane/v1/MsgSetDestinationGasConfig", nil)
3839
cdc.RegisterConcrete(&types.MsgSetIgpOwner{}, "hyperlane/v1/MsgSetIgpOwner", nil)
39-
40-
// TODO
41-
// Duplicates are not allowed. This will be fixed with https://github.com/bcp-innovations/hyperlane-cosmos/pull/123
42-
// cdc.RegisterConcrete(&pdtypes.MsgCreateNoopHook{}, "hyperlane/v1/MsgCreateMerkleTreeHook", nil)
4340
}

0 commit comments

Comments
 (0)