Fix unreliable DnnMvcHandler.DisableMvcResponseHeader

Author: dimarobert

DNN Platform/DotNetNuke.Web.Mvc/DnnMvcHandler.cs

@@ -130,7 +130,7 @@ private ModuleRequestContext GetModuleRequestContext(HttpContextBase httpContext
             {
                 HttpContext = httpContext,
                 ModuleContext = moduleContext,
-                ModuleApplication = new ModuleApplication(this.RequestContext, DisableMvcResponseHeader)
+                ModuleApplication = new ModuleApplication(this.RequestContext)
                 {
                     ModuleName = desktopModule.ModuleName,
                     FolderPath = desktopModule.FolderName,

DNN Platform/DotNetNuke.Web.Mvc/Framework/Modules/ModuleApplication.cs

@@ -32,20 +32,23 @@ public class ModuleApplication
         private bool initialized;
 
         public ModuleApplication()
-            : this(null, false)
+            : this(null)
         {
         }
 
         public ModuleApplication(bool disableMvcResponseHeader)
-            : this(null, disableMvcResponseHeader)
+            : this(null)
         {
         }
 
         public ModuleApplication(RequestContext requestContext, bool disableMvcResponseHeader)
+            : this(requestContext)
         {
-            this.RequestContext = requestContext;
+        }
 
-            DisableMvcResponseHeader = disableMvcResponseHeader;
+        public ModuleApplication(RequestContext requestContext)
+        {
+            this.RequestContext = requestContext;
 
             // ReSharper disable once DoNotCallOverridableMethodsInConstructor
             this.ControllerFactory = Globals.GetCurrentServiceProvider().GetRequiredService<IControllerFactory>();
@@ -70,8 +73,6 @@ public ModuleApplication(RequestContext requestContext, bool disableMvcResponseH
 
         public ViewEngineCollection ViewEngines { get; set; }
 
-        private static bool DisableMvcResponseHeader { get; set; }
-
         public virtual ModuleRequestResult ExecuteRequest(ModuleRequestContext context)
         {
             this.EnsureInitialized();
@@ -164,7 +165,7 @@ protected internal virtual void Init()
 
         protected internal virtual void AddVersionHeader(HttpContextBase httpContext)
         {
-            if (!DisableMvcResponseHeader)
+            if (!DnnMvcHandler.DisableMvcResponseHeader)
             {
                 httpContext.Response.AppendHeader(MvcVersionHeaderName, MvcVersion);
             }