add typing-extensions for py < 3.12, use override

Author: yagebu

constraints-old.txt

@@ -158,6 +158,8 @@ texttable==0.8.1
     # via pyexcel
 tomli==1.0.0
     # via pytest
+typing-extensions==4.5.0
+    # via fava (pyproject.toml)
 watchfiles==0.20.0
     # via fava (pyproject.toml)
 werkzeug==2.2.0

pyproject.toml

@@ -47,6 +47,7 @@ dependencies = [
     "ply>=3.4",
     "simplejson>=3.16.0,<4",
     "watchfiles>=0.20.0",
+    "typing-extensions>=4.5; python_version<\"3.12\"",
 ]
 
 [project.urls]

src/fava/core/conversion.py

@@ -12,6 +12,11 @@
 from fava.core.inventory import _Amount
 from fava.core.inventory import SimpleCounterInventory
 
+try:
+    from typing import override
+except ImportError:  # pragma: no cover
+    from typing_extensions import override
+
 if TYPE_CHECKING:  # pragma: no cover
     import datetime
 
@@ -125,16 +130,18 @@ def apply(
 
 
 class _AtCostConversion(Conversion):
+    @override
     def apply(
         self,
         inventory: CounterInventory,
-        prices: FavaPriceMap | None = None,  # noqa: ARG002
-        date: datetime.date | None = None,  # noqa: ARG002
+        prices: FavaPriceMap | None = None,
+        date: datetime.date | None = None,
     ) -> SimpleCounterInventory:
         return inventory.reduce(get_cost)
 
 
 class _AtValueConversion(Conversion):
+    @override
     def apply(
         self,
         inventory: CounterInventory,
@@ -145,11 +152,12 @@ def apply(
 
 
 class _UnitsConversion(Conversion):
+    @override
     def apply(
         self,
         inventory: CounterInventory,
-        prices: FavaPriceMap | None = None,  # noqa: ARG002
-        date: datetime.date | None = None,  # noqa: ARG002
+        prices: FavaPriceMap | None = None,
+        date: datetime.date | None = None,
     ) -> SimpleCounterInventory:
         counter = SimpleCounterInventory()
         for (currency, _cost), number in inventory.items():
@@ -173,6 +181,7 @@ class _CurrencyConversion(Conversion):
     def __init__(self, value: str) -> None:
         self._currencies = tuple(value.split(","))
 
+    @override
     def apply(
         self,
         inventory: CounterInventory,

src/fava/util/date.py

@@ -20,6 +20,11 @@
 
 from fava.util import listify
 
+try:
+    from typing import override
+except ImportError:  # pragma: no cover
+    from typing_extensions import override
+
 if TYPE_CHECKING:  # pragma: no cover
     from collections.abc import Iterable
     from collections.abc import Iterator
@@ -202,7 +207,8 @@ def get_next(self, date: datetime.date) -> datetime.date:
         except OverflowError:
             return datetime.date.max
 
-    def number_of_days(self, date: datetime.date) -> int:  # noqa: ARG002
+    @override
+    def number_of_days(self, date: datetime.date) -> int:
         """Get number of days in the surrounding interval."""
         return 7
 
@@ -226,7 +232,8 @@ def get_next(self, date: datetime.date) -> datetime.date:
         except OverflowError:
             return datetime.date.max
 
-    def number_of_days(self, date: datetime.date) -> int:  # noqa: ARG002
+    @override
+    def number_of_days(self, date: datetime.date) -> int:
         return 1
 
 

tests/data/import_config.py

@@ -14,6 +14,11 @@
 from fava.beans import create
 from fava.beans.ingest import BeanImporterProtocol
 
+try:
+    from typing import override
+except ImportError:
+    from typing_extensions import override
+
 if TYPE_CHECKING:  # pragma: no cover
     from collections.abc import Sequence
     from typing import Any
@@ -27,20 +32,24 @@
 class TestBeangulpImporterNoExtraction(Importer):
     """Importer with the beangulp interface that doesn't extract entries."""
 
+    @override
     def identify(self, filepath: str) -> bool:
         return Path(filepath).name == "import.csv"
 
-    def account(self, filepath: str) -> str:  # noqa: ARG002
+    @override
+    def account(self, filepath: str) -> str:
         return "Assets:Checking"
 
-    def date(self, filepath: str) -> datetime.date:  # noqa: ARG002
+    @override
+    def date(self, filepath: str) -> datetime.date:
         return DATE
 
 
 class TestBeangulpImporter(TestBeangulpImporterNoExtraction):
     """Importer with the beangulp interface."""
 
-    def extract(self, filepath: str, existing: Any) -> list[Directive]:  # noqa: ARG002
+    @override
+    def extract(self, filepath: str, existing: Any) -> list[Directive]:
         entries: list[Directive] = []
         path = Path(filepath)
         account = self.account(filepath)
@@ -107,18 +116,23 @@ class TestImporter(BeanImporterProtocol):
     account = "Assets:Checking"
     currency = "EUR"
 
+    @override
     def identify(self, file: FileMemo) -> bool:
         return Path(file.name).name == "import.csv"
 
+    @override
     def file_name(self, file: FileMemo) -> str:
         return f"examplebank.{Path(file.name).name}"
 
-    def file_account(self, file: FileMemo) -> str:  # noqa: ARG002
+    @override
+    def file_account(self, file: FileMemo) -> str:
         return self.account
 
-    def file_date(self, file: FileMemo) -> datetime.date:  # noqa: ARG002
+    @override
+    def file_date(self, file: FileMemo) -> datetime.date:
         return DATE
 
+    @override
     def extract(
         self,
         file: FileMemo,
@@ -129,9 +143,10 @@ def extract(
 
 
 class TestImporterThatErrorsOnExtract(TestImporter):
+    @override
     def extract(
         self,
-        file: FileMemo,  # noqa: ARG002
+        file: FileMemo,
         **_kwargs: Any,
     ) -> list[Directive]:
         raise TypeError