Commit 8c8ff84
Disambiguate codesign identity in repack-dmg.sh (#7)
The v0.2.0 third-attempt run (24573078620) got all the way through macOS
signing + notarization + DMG creation, then died re-signing the DMG
wrapper inside create-dmg:
***: ambiguous (matches "iPhone Distribution: ***" and
"Developer ID Application: ***" in
/Users/runner/work/_temp/skiller-build.keychain-db)
The GitHub Actions macOS runner keychain happens to also have an
"iPhone Distribution" cert, and the bare CSC_NAME value (which is the
post-prefix identity name only) matches both. electron-builder itself
filters by identity *type* internally so it didn't care; /usr/bin/codesign
has no such filter.
Fix: prepend `Developer ID Application: ` back when calling create-dmg's
`--codesign`. Strip first so the operation is idempotent whether CSC_NAME
is stored in bare form (new convention) or with prefix (legacy local .env).
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 1d6ef7c commit 8c8ff84
1 file changed
Lines changed: 8 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | | - | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
56 | 63 | | |
57 | 64 | | |
58 | 65 | | |
| |||
0 commit comments