warning: use of `unwrap_or` to construct default value --> src/elastic_push.rs:54:44 | 54 | let body = make_json_body(&buffer).unwrap_or(vec![]); | ^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default = note: `#[warn(clippy::unwrap_or_default)]` on by default

warning: redundant closure --> src/elastic_push.rs:32:14 | 32 | .map(|e| json_from_logrecord(e)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `json_from_logrecord` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure = note: `#[warn(clippy::redundant_closure)]` on by default

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> src/elastic_push.rs:26:14 | 26 | records: &Vec<LogRecord>, | ^^^^^^^^^^^^^^^ help: change this to: `&[LogRecord]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default

warning: function call inside of `expect` --> src/redis_logs.rs:224:15 | 224 | create_id.expect(&format!( | _______________^ 225 | | "Failed to create Redis consumer ID {} in group {}!", 226 | | &config.consumer_id, &config.consumer_group 227 | | )); | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call = note: `#[warn(clippy::expect_fun_call)]` on by default help: try | 224 ~ create_id.unwrap_or_else(|_| panic!("Failed to create Redis consumer ID {} in group {}!", 225 ~ &config.consumer_id, &config.consumer_group)); |

warning: called `iter().cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable --> src/redis_logs.rs:180:48 | 180 | redis::Value::BulkString(x) => Ok(x.iter().cloned().collect()), | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect = note: `#[warn(clippy::iter_cloned_collect)]` on by default

warning: accessing first element with `raw_reply .keys.get(0)` --> src/redis_logs.rs:161:19 | 161 | let log_key = raw_reply | ___________________^ 162 | | .keys 163 | | .get(0) | |_______________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `#[warn(clippy::get_first)]` on by default help: try | 161 ~ let log_key = raw_reply 162 + .keys.first() |

warning: passing a unit value to a function --> src/redis_logs.rs:129:27 | 129 | metadata: {}.into(), | --^^^^^^^ | | | help: use a unit literal instead: `()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg

warning: passing a unit value to a function --> src/redis_logs.rs:98:32 | 98 | extra: {}.into(), | --^^^^^^^ | | | help: use a unit literal instead: `()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg = note: `#[warn(clippy::unit_arg)]` on by default