ci: remove concurrency block and require test for release #40
d-perlAnnotations
20 warnings
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Check
`bec_log_ingestor` (bin "bec_log_ingestor") generated 1 warning (run `cargo fix --bin "bec_log_ingestor"` to apply 1 suggestion)
|
|
Check:
src/elastic_push.rs#L8
unused import: `LogRecord`
|
|
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
use of `unwrap_or` to construct default value:
src/main.rs#L67
warning: use of `unwrap_or` to construct default value
--> src/elastic_push.rs:67:44
|
67 | let body = make_json_body(&buffer).unwrap_or(vec![]);
| ^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
= note: `#[warn(clippy::unwrap_or_default)]` on by default
|
|
redundant closure:
src/main.rs#L46
warning: redundant closure
--> src/elastic_push.rs:46:14
|
46 | .map(|e| json_from_logmsg(e))
| ^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `json_from_logmsg`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
|
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
src/main.rs#L40
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> src/elastic_push.rs:40:11
|
40 | msgs: &Vec<LogMsg>,
| ^^^^^^^^^^^^ help: change this to: `&[LogMsg]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
|
|
function call inside of `expect`:
src/main.rs#L232
warning: function call inside of `expect`
--> src/redis_logs.rs:232:15
|
232 | create_id.expect(&format!(
| _______________^
233 | | "Failed to create Redis consumer ID {} in group {}!",
234 | | &config.consumer_id, &config.consumer_group
235 | | ));
| |______^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
= note: `#[warn(clippy::expect_fun_call)]` on by default
help: try
|
232 ~ create_id.unwrap_or_else(|_| panic!("Failed to create Redis consumer ID {} in group {}!",
233 ~ &config.consumer_id, &config.consumer_group));
|
|
|
called `iter().cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable:
src/main.rs#L188
warning: called `iter().cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable
--> src/redis_logs.rs:188:48
|
188 | redis::Value::BulkString(x) => Ok(x.iter().cloned().collect()),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect
= note: `#[warn(clippy::iter_cloned_collect)]` on by default
|
|
accessing first element with `raw_reply
.keys.get(0)`:
src/main.rs#L169
warning: accessing first element with `raw_reply
.keys.get(0)`
--> src/redis_logs.rs:169:19
|
169 | let log_key = raw_reply
| ___________________^
170 | | .keys
171 | | .get(0)
| |_______________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
= note: `#[warn(clippy::get_first)]` on by default
help: try
|
169 ~ let log_key = raw_reply
170 + .keys.first()
|
|
|
passing a unit value to a function:
src/main.rs#L137
warning: passing a unit value to a function
--> src/redis_logs.rs:137:27
|
137 | metadata: {}.into(),
| --^^^^^^^
| |
| help: use a unit literal instead: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
|
|
passing a unit value to a function:
src/main.rs#L106
warning: passing a unit value to a function
--> src/redis_logs.rs:106:32
|
106 | extra: {}.into(),
| --^^^^^^^
| |
| help: use a unit literal instead: `()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
= note: `#[warn(clippy::unit_arg)]` on by default
|
|
unused import: `LogRecord`:
src/main.rs#L8
warning: unused import: `LogRecord`
--> src/elastic_push.rs:8:26
|
8 | redis_logs::{LogMsg, LogRecord},
| ^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
this import is redundant:
src/main.rs#L3
warning: this import is redundant
--> src/redis_logs.rs:3:1
|
3 | use rmp_serde;
| ^^^^^^^^^^^^^^ help: remove it entirely
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
= note: `#[warn(clippy::single_component_path_imports)]` on by default
|