feat: retry redis connection #182
d-perlcheck-and-lint.yaml
on: pull_request
Check
2m 25s
Rustfmt
15s
Clippy
2m 29s
Test cross compilation and RPM build
2m 36s
Annotations
1 error and 15 warnings
|
Rustfmt
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
passing a unit value to a function:
src/main.rs#L130
warning: passing a unit value to a function
--> src/redis_logs.rs:130:17
|
130 | / Ok(println!(
131 | | "Group {} already exists, rejoining with ID {}",
132 | | &config.redis.consumer_group, &config.redis.consumer_id
133 | | ))
| |__________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#unit_arg
= note: `#[warn(clippy::unit_arg)]` on by default
help: move the expression in front of the call and replace it with the unit literal `()`
|
130 ~ println!(
131 + "Group {} already exists, rejoining with ID {}",
132 + &config.redis.consumer_group, &config.redis.consumer_id
133 + );
134 + Ok(())
|
|
|
called `unwrap` on `new_conn` after checking its variant with `is_err`:
src/main.rs#L47
warning: called `unwrap` on `new_conn` after checking its variant with `is_err`
--> src/redis_logs.rs:47:28
|
42 | if new_conn.is_err() {
| -------------------- help: try: `if let Ok(<item>) = new_conn`
...
47 | let mut conn = new_conn.unwrap();
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#unnecessary_unwrap
= note: `#[warn(clippy::unnecessary_unwrap)]` on by default
|
|
name `ERROR` contains a capitalized acronym:
src/main.rs#L242
warning: name `ERROR` contains a capitalized acronym
--> src/status_message.rs:242:5
|
242 | ERROR = -1,
| ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Error`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#upper_case_acronyms
|
|
name `IDLE` contains a capitalized acronym:
src/main.rs#L241
warning: name `IDLE` contains a capitalized acronym
--> src/status_message.rs:241:5
|
241 | IDLE = 0,
| ^^^^ help: consider making the acronym lowercase, except the initial letter: `Idle`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#upper_case_acronyms
|
|
name `BUSY` contains a capitalized acronym:
src/main.rs#L240
warning: name `BUSY` contains a capitalized acronym
--> src/status_message.rs:240:5
|
240 | BUSY = 1,
| ^^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Busy`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#upper_case_acronyms
|
|
name `RUNNING` contains a capitalized acronym:
src/main.rs#L239
warning: name `RUNNING` contains a capitalized acronym
--> src/status_message.rs:239:5
|
239 | RUNNING = 2,
| ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Running`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#upper_case_acronyms
= note: `#[warn(clippy::upper_case_acronyms)]` on by default
|
|
large size difference between variants:
src/main.rs#L109
warning: large size difference between variants
--> src/status_message.rs:109:1
|
109 | / pub enum Info {
110 | | ServiceInfo(ServiceInfoMessagePack),
| | ----------------------------------- the largest variant contains at least 232 bytes
111 | | Object(::serde_json::Map<::std::string::String, ::serde_json::Value>),
| | --------------------------------------------------------------------- the second-largest variant contains at least 24 bytes
112 | | }
| |_^ the entire enum is at least 232 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum
|
110 - ServiceInfo(ServiceInfoMessagePack),
110 + ServiceInfo(Box<ServiceInfoMessagePack>),
|
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
Test binary artifact and RPM
|
6.44 MB |
sha256:3ae8cb23831a3354337669f7f453d8283928c8daae52f91df8e7d243bbf078ee
|
|