Clean up empty questionnaire response items

Author: ruscoder

CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.0.0-beta.4
+
+- Clean up empty questionnaire response items
+
 ## 1.0.0-beta.3
 
 - Clean up empty answers key from questionnaire response item

package.json

@@ -1,7 +1,7 @@
 {
   "name": "sdc-qrf",
   "license": "MIT",
-  "version": "1.0.0-beta.3",
+  "version": "1.0.0-beta.4",
   "scripts": {
     "test": "vitest --watch=false",
     "test:watch": "vitest --watch",

src/utils.ts

@@ -265,11 +265,15 @@ function mapFormToResponseRecursive(
                 ];
             }, [] as QuestionnaireResponseItemAnswer[]);
 
+        if (!qrItemAnswers.length) {
+            return acc;
+        }
+
         return [
             ...acc,
             {
                 linkId,
-                ...(qrItemAnswers.length ? { answer: qrItemAnswers } : {}),
+                answer: qrItemAnswers,
             },
         ];
     }, [] as QuestionnaireResponseItem[]);

tests/resources/questionnaire.ts

@@ -1,6 +1,5 @@
 import { describe, expect, test, vi } from 'vitest';
 
-import { allergiesQuestionnaire } from './resources/questionnaire';
 import {
     calcContext,
     calcInitialContext,
@@ -744,18 +743,6 @@ test('Transform removes missing answers', () => {
             {
                 linkId: 'root-group',
                 item: [
-                    {
-                        linkId: 'question-1',
-                    },
-                    {
-                        linkId: 'question-2',
-                    },
-                    {
-                        linkId: 'question-3',
-                    },
-                    {
-                        linkId: 'question-4',
-                    },
                     {
                         answer: [
                             {
@@ -1439,33 +1426,6 @@ test('enableWhenExpression logic', () => {
     expect(actualQR).toEqual(expectedQR);
 });
 
-test('mapFormToResponse cut empty answers', () => {
-    const formValues = {
-        type: [
-            {
-                value: {
-                    Coding: {
-                        code: '418634005',
-                        system: 'http://snomed.ct',
-                        display: 'Drug',
-                    },
-                },
-            },
-        ],
-        reaction: undefined,
-        notes: [
-            {
-                value: {},
-            },
-        ],
-    };
-
-    const result = mapFormToResponse(formValues, allergiesQuestionnaire);
-    const answersLinkIds = result.item?.map((answerItem) => answerItem.linkId) ?? [];
-    expect(answersLinkIds.includes('reaction')).not.toBe(true);
-    expect(answersLinkIds).toEqual(expect.arrayContaining(['type', 'notes']));
-});
-
 describe('enableWhen exists logic for non-repeatable groups primitives', () => {
     const testConfigs: Array<{ name: string; q: FCEQuestionnaireItem; qr: QuestionnaireResponseItem[] }> = [
         {